Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2024 prod-like workflow and fix DIGI-HLT prodlike step #44525

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Mar 24, 2024

PR description:

This PR adds 2024 prodlike workflows to runTheMatrix. I also use this chance to remove hardcoding DIGI-HLT step in prodlike wf which, currently, HLT step does not reflect the proper menu.

PR validation:

Dump configs of 2024 and Phase-2 are OK.
runTheMatrix.py --what upgrade -l 12834.21,25234.21 --wm init

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No need of backport.

FYI @cms-sw/reconstruction-l2 @cms-sw/hlt-l2

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 24, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44525/39656

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @srimanob for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@srimanob, @cmsbuild, @subirsarkar, @sunilUIET, @miquork, @AdrianoDee can you please review it and eventually sign? Thanks.
@slomeo, @fabiocos, @missirol, @Martin-Grunewald, @makortel this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

@cmsbuild please test workflows 12834.21,25234.21

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f4144/38367/summary.html
COMMIT: 47b5c21
CMSSW: CMSSW_14_1_X_2024-03-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44525/38367/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 12834.21, 25234.21

@srimanob
Copy link
Contributor Author

test parameters:

  • workflows = 12834.21,25234.21
  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,2026

@srimanob
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f4144/38368/summary.html
COMMIT: 47b5c21
CMSSW: CMSSW_14_1_X_2024-03-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44525/38368/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 8 lines from the logs
  • Reco comparison results: 50 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297537
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3297508
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor Author

+Upgrade

New prod-like workflows have the proper DIGI-HLT sequence.

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants