-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0.X] TkAl: fix PV validation and PV resolution submission scripts #44468
[14.0.X] TkAl: fix PV validation and PV resolution submission scripts #44468
Conversation
A new Pull Request was created by @mmusich for CMSSW_14_0_X. It involves the following packages:
@perrotta, @consuegs, @cmsbuild, @saumyaphor4252 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
a9842ff
to
98cbc90
Compare
Pull request #44468 was updated. @saumyaphor4252, @cmsbuild, @consuegs, @perrotta can you please check and sign again. |
98cbc90
to
824278a
Compare
Pull request #44468 was updated. @cmsbuild, @consuegs, @saumyaphor4252, @perrotta can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49b002/38275/summary.html Comparison SummarySummary:
|
type bug-fix |
no, even if it's harmless, it should be commented (or even removed) also here, because that script is not accessible when executing unit tests: ./batchHarvester_Prompt_0.sh: line 2: /afs/cern.ch/cms/caf/setup.sh: No such file or directory at the end of the log file |
…Jobs to run in recent releas
…ions to be used. Also refresh the input data
824278a
to
e476972
Compare
Pull request #44468 was updated. @perrotta, @consuegs, @cmsbuild, @saumyaphor4252 can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49b002/38321/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #44467
PR description:
The goal of this PR is to fix the scripts
submitPVResolutionJobs.py
andsubmitPVValidationJobs.py
such that they can run in recent releases and with recent (Run 3) data.The related unit tests are improved such that, in addition to technically creating the configuration to be run with HTCondor, said configuration is also tested for at least one job (running locally).
PR validation:
Run successfully:
scram b runtests_SubmitPVsplit
scram b runtests_SubmitPVrbr
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Verbatim backport of #44467 for the 2024 data-taking release