Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 14_0_X (4/N) [14_1_X] #44415

Merged
merged 5 commits into from
Mar 15, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 15, 2024

PR description:

Development of HLT menus for CMSSW_14_0_X (branch CMSSW_14_1_X).

  • This is the PR for the master branch, which will then be backported down to 14_0_X (the latter is the release cycle currently used for Run-3 HLT-menu development).

This version of the GRun HLT menu corresponds to final list of updates to the "V1.0" menu for the 2024 pp data-taking period.

This update includes the integration of the following JIRA tickets:

  • CMSHLT-3092 [TSG] Completion of the offline "Special" table and lists of paths for individual special menus [14_0_X]
  • CMSHLT-3099 [BPH] Include L1 seed to Dimuon low pt Jpsi trigger
  • CMSHLT-3101 [Scouting] Storage of raw AK4PFJets in Scouting
  • CMSHLT-3103 [TSG] Undo GRun changes due to CMSHLT-2860 (MinimumBias PD, smart-PS of HLT_ZeroBias in EventDisplay)
  • CMSHLT-3104 [BTV] Migration of MC_PFBTag to ParticleNet
  • CMSHLT-3109 [ECAL/PF] Integrate Alpaka version of ECAL local reco and PFRecHit+PFCluster reco of HBHE RecHits

In addition, the following changes are included:

  • 5e266bd robustify test_OnlineVsDevTablesConsistency
  • 8e75dc3 add Special subtable to DEV / dev cmsDriver tests
  • 5f19fd1 Introduce 2024v1.0 frozen menu and remove 2023v1.2 and related test machinery.
  • ce8e531 update readme in HLTrigger/Configuration/scripts/utils to CMSSW_14_0_0

PR validation:

TSG Integration tests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but it will be backported to CMSSW_14_0_X.

mmusich added 5 commits March 15, 2024 11:40
This version of the GRun HLT menu corresponds to final list of updates to the "V1.0" menu for the 2024 pp data-taking period.
This update includes the integration of the following JIRA tickets:
- [CMSHLT-3092](https://its.cern.ch/jira/browse/CMSHLT-3092) [TSG] Completion of the offline "Special" table and lists of paths for individual special menus [14_0_X]
- [CMSHLT-3099](https://its.cern.ch/jira/browse/CMSHLT-3099) [BPH] Include L1 seed to Dimuon low pt Jpsi trigger
- [CMSHLT-3101](https://its.cern.ch/jira/browse/CMSHLT-3101) [Scouting] Storage of raw AK4PFJets in Scouting
- [CMSHLT-3103](https://its.cern.ch/jira/browse/CMSHLT-3103) [TSG] Undo GRun changes due to CMSHLT-2860 (MinimumBias PD, smart-PS of HLT_ZeroBias in EventDisplay)
- [CMSHLT-3104](https://its.cern.ch/jira/browse/CMSHLT-3104) [BTV] Migration of MC_PFBTag to ParticleNet
- [CMSHLT-3109](https://its.cern.ch/jira/browse/CMSHLT-3109) [ECAL/PF] Integrate Alpaka version of ECAL local reco and PFRecHit+PFCluster reco of HBHE RecHits
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 15, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44415/39488

  • This PR adds an extra 1348KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Configuration/HLT (hlt)
  • HLTrigger/Configuration (hlt)

@mmusich, @Martin-Grunewald, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos, @missirol, @Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Mar 15, 2024

enable gpu

@mmusich
Copy link
Contributor Author

mmusich commented Mar 15, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c1724/38160/summary.html
COMMIT: ce8e531
CMSSW: CMSSW_14_1_X_2024-03-14-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44415/38160/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 78 lines to the logs
  • Reco comparison results: 57 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3288140
  • DQMHistoTests: Total failures: 4687
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3283433
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -1.092 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): -0.156 KiB HLT/Filters
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 7 / 46 workflows

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 35 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 1411
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 38329
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@antoniovilela
Copy link
Contributor

+1

  • HLT dump.

@mmusich
Copy link
Contributor Author

mmusich commented Mar 15, 2024

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 7827a07 into cms-sw:master Mar 15, 2024
14 checks passed
@mmusich mmusich deleted the HLTdevelopment140X_for141X branch March 15, 2024 14:42
@mmusich
Copy link
Contributor Author

mmusich commented Mar 19, 2024

type hlt-integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants