Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change FEStatus flag labels in ECAL DQM [14_0_X] #44404

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

kyungminparkdrums
Copy link

@kyungminparkdrums kyungminparkdrums commented Mar 14, 2024

PR description:

This PR changes the flag labels of the FE Status plots in the ECAL DQM plot

  • FIFOFULL -> FORCEDFULLSUPP
  • FULLL1ADESYNC -> FIFOFULL

PR validation:

PR is validated by running the ECAL online DQM configuration and verifying the plots on a test DQM GUI.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is the backport to 14_0_X, which is used in production at the moment. Master PR is #44402

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kyungminparkdrums for CMSSW_14_0_X.

It involves the following packages:

  • DQM/EcalCommon (dqm)
  • DQM/EcalMonitorClient (dqm)
  • DQM/EcalMonitorTasks (dqm)

@cmsbuild, @rvenditti, @syuvivida, @antoniovagnerini, @nothingface0, @tjavaid can you please review it and eventually sign? Thanks.
@argiro, @rchatter, @wang0jin, @ReyerBand, @thomreis this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 14, 2024

cms-bot internal usage

@kyungminparkdrums kyungminparkdrums marked this pull request as ready for review March 14, 2024 14:43
@tjavaid
Copy link

tjavaid commented Mar 14, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6df56/38141/summary.html
COMMIT: af23692
CMSSW: CMSSW_14_0_X_2024-03-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44404/38141/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@tjavaid
Copy link

tjavaid commented Mar 19, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Please always sign the master before the backport.
Thanks.

@antoniovilela
Copy link
Contributor

The master PR is not yet signed.

@tjavaid
Copy link

tjavaid commented Mar 21, 2024

+1

Please always sign the master before the backport. Thanks.

Just signed. Thanks!

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ac46a1e into cms-sw:CMSSW_14_0_X Mar 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants