BaseMVAValueMapProducer configuration and parameter validation

[vlimant]

PR description:

the original implementation of BaseMVAValueMapProducer turns out to be quite cumbersome ; this PR makes it slimmer and hopefully less error-prone

PR validation:

nano matrix

tagging @arizzi

[vlimant]

enable nano

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44392/39453

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/electrons_cff.py modified in PR(s): Implemented new modifiers for mvaTTH Run 3 #44322
  • File PhysicsTools/NanoAOD/python/muons_cff.py modified in PR(s): Implemented new modifiers for mvaTTH Run 3 #44322

[cmsbuild]

A new Pull Request was created by @vlimant for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)
• PhysicsTools/PatAlgos (xpog, reconstruction)

@hqucms, @mandrenguyen, @cmsbuild, @jfernan2, @vlimant can you please review it and eventually sign? Thanks.
@andrzejnovak, @mmarionncern, @mariadalfonso, @azotz, @Ming-Yan, @hatakeyamak, @emilbols, @nhanvtran, @jdamgov, @schoef, @gouskos, @ahinzmann, @gkasieczka, @rappoccio, @mbluj, @JyothsnaKomaragiri, @gpetruc, @AlexDeMoor, @Senphy, @seemasharmafnal, @AnnikaStein, @jdolen, @demuller this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[vlimant]

type muon

[vlimant]

type jetmet

[vlimant]

type egamma

[vlimant]

please test

[vlimant]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44392/39474

• This PR adds an extra 40KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/electrons_cff.py modified in PR(s): Implemented new modifiers for mvaTTH Run 3 #44322
  • File PhysicsTools/NanoAOD/python/muons_cff.py modified in PR(s): Implemented new modifiers for mvaTTH Run 3 #44322

[cmsbuild]

Pull request #44392 was updated. @mandrenguyen, @jfernan2, @hqucms, @vlimant can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-951c12/38131/summary.html
COMMIT: d086c53
CMSSW: CMSSW_14_1_X_2024-03-13-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44392/38131/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 49 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297383
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297360
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 16402
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 16402
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
• Checked 45 log files, 25 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.548	2.548	0.000 ( +0.0% )	5.26	5.10	+3.2%	2.216	2.220
2500.001	2.698	2.698	0.000 ( +0.0% )	4.65	4.60	+1.2%	2.641	2.658
2500.002	2.638	2.638	0.000 ( +0.0% )	4.88	4.72	+3.4%	2.643	2.650
2500.01	1.318	1.318	0.000 ( +0.0% )	9.77	9.42	+3.7%	2.282	2.331
2500.011	1.740	1.740	0.000 ( +0.0% )	5.27	5.16	+2.2%	2.451	2.534
2500.012	1.581	1.581	0.000 ( +0.0% )	7.51	7.25	+3.6%	2.353	2.441
2500.1	2.192	2.192	0.000 ( +0.0% )	5.32	5.30	+0.4%	2.057	2.061
2500.2	2.308	2.308	0.000 ( +0.0% )	6.05	6.04	+0.3%	1.970	1.968
2500.21	1.181	1.181	0.000 ( +0.0% )	4.33	4.31	+0.4%	2.266	2.272
2500.211	1.545	1.545	0.000 ( +0.0% )	3.73	3.71	+0.6%	2.353	2.353
2500.3	2.058	2.058	0.000 ( +0.0% )	12.64	12.12	+4.3%	1.956	1.959
2500.301	2.631	2.631	0.000 ( +0.0% )	10.13	9.90	+2.3%	1.949	1.941
2500.31	1.254	1.254	0.000 ( +0.0% )	19.79	19.43	+1.8%	2.359	2.357
2500.311	1.640	1.640	0.000 ( +0.0% )	13.57	13.73	-1.2%	2.438	2.433
2500.312	7.159	7.159	0.000 ( +0.0% )	1.36	1.42	-4.0%	1.685	1.679
2500.313	1.564	1.564	0.000 ( +0.0% )	5.67	6.86	-17.4%	1.030	1.030
2500.314	1.163	1.163	0.000 ( +0.0% )	13.66	14.64	-6.7%	2.058	2.201
2500.315	1.758	1.758	0.000 ( +0.0% )	13.96	13.13	+6.4%	2.321	2.351
2500.316	1.787	1.787	0.000 ( +0.0% )	13.09	13.18	-0.7%	2.161	2.350
2500.4	2.058	2.058	0.000 ( +0.0% )	12.42	12.39	+0.3%	1.850	1.965
2500.401	1.824	1.824	0.000 ( +0.0% )	10.31	9.56	+7.9%	1.812	1.812
2500.402	2.631	2.631	0.000 ( +0.0% )	9.72	9.81	-0.9%	1.935	1.952
2500.403	2.620	2.620	0.000 ( +0.0% )	10.33	10.02	+3.1%	1.948	1.950
2500.5	19.575	19.575	0.000 ( +0.0% )	1.14	1.07	+6.5%	1.342	1.343

[vlimant]

+1

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1