-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix how empty FileInPaths are handled in python #44362
Conversation
urgent |
please test |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44362/39407
|
A new Pull Request was created by @Dr15Jones for master. It involves the following packages:
@makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
- set a default value in python - have the cfi generator still add the default blank string
f7fe407
to
4f6cf22
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44362/39408
|
Pull request #44362 was updated. @cmsbuild, @makortel, @Dr15Jones, @smuzaffar can you please check and sign again. |
ping bot |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4565c2/38024/summary.html Comparison SummarySummary:
|
core +1 |
+core Doing this to give anyone in Europe a head start to integrate this |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR validation:
Unit tests pass.