Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport to 14_0_0] Moved ONNXRuntime headers in 1.17.1 #44355

Open
wants to merge 1 commit into
base: CMSSW_14_0_X
Choose a base branch
from

Conversation

valsdav
Copy link
Contributor

@valsdav valsdav commented Mar 8, 2024

PR description:

Updating ONNXRuntime to 1.17.1 to be able to update CUDA to 12.4.
Backport to 14_0_X branch.

  • Headers have been moved in ONNXRuntime 1.17.1

PR validation:

To be tested with cms-sw/cmsdist#9051 [backport to 14.0.x]

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2024

A new Pull Request was created by @valsdav for CMSSW_14_0_X.

It involves the following packages:

  • PhysicsTools/ONNXRuntime (ml)

@valsdav, @wpmccormack, @cmsbuild can you please review it and eventually sign? Thanks.
@riga, @AnnikaStein this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor

fwyzard commented Mar 8, 2024

backport of #44354

@fwyzard
Copy link
Contributor

fwyzard commented Mar 8, 2024

please test with cms-sw/cmsdist#9051

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2024

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e9aa6/37988/summary.html
COMMIT: d376e1e
CMSSW: CMSSW_14_0_X_2024-03-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44355/37988/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e9aa6/37988/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e9aa6/37988/git-merge-result

Build

I found compilation error when building:

>> Compiling edm plugin src/RecoLocalCalo/HcalRecProducers/src/HcalSimpleReconstructor.cc
>> Compiling  src/RecoLocalCalo/HcalRecProducers/src/MahiGPU.cu
>> Compiling edm plugin src/RecoLocalCalo/HcalRecProducers/src/SealModule.cc
>> Compiling edm plugin src/RecoLocalCalo/HcalRecProducers/src/ZdcHitReconstructor.cc
>> Compiling edm plugin src/RecoLocalCalo/HcalRecProducers/src/ZdcSimpleReconstructor.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/lib/gcc/x86_64-redhat-linux-gnu/12.3.1/include/avx512bf16vlintrin.h(53): error: identifier "__builtin_ia32_cvtne2ps2bf16_v16hi" is undefined
    return (__m256bh)__builtin_ia32_cvtne2ps2bf16_v16hi(__A, __B);
                     ^

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/lib/gcc/x86_64-redhat-linux-gnu/12.3.1/include/avx512bf16vlintrin.h(60): error: identifier "__builtin_ia32_cvtne2ps2bf16_v16hi_mask" is undefined
    return (__m256bh)__builtin_ia32_cvtne2ps2bf16_v16hi_mask(__C, __D, __A, __B);


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Entering Package Utilities/ReleaseScripts
>> Entering Package Utilities/StaticAnalyzers
>> Entering Package Utilities/StorageFactory
>> Entering Package Utilities/XrdAdaptor
>> Compile sequence completed for CMSSW CMSSW_14_0_X_2024-03-08-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-03-08-1100/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package PhysicsTools/NanoAODTools
------- copying files from src/PhysicsTools/NanoAODTools/scripts -------
>> copied nano_postproc.py


@fwyzard
Copy link
Contributor

fwyzard commented Mar 10, 2024

please test with cms-sw/cmsdist#9051

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e9aa6/38022/summary.html
COMMIT: d376e1e
CMSSW: CMSSW_14_0_X_2024-03-10-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44355/38022/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 16 lines to the logs
  • Reco comparison results: 48 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3342271
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3342240
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@antoniovilela
Copy link
Contributor

hold

  • As discussed at ORP.

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @antoniovilela
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@fwyzard
Copy link
Contributor

fwyzard commented Apr 11, 2024

please test with #44355

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e9aa6/38800/summary.html
COMMIT: d376e1e
CMSSW: CMSSW_14_0_X_2024-04-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44355/38800/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Leaving Package PhysicsTools/ONNXRuntime
>> Package PhysicsTools/ONNXRuntime built
Entering library rule at PhysicsTools/ONNXRuntime
>> Compiling  src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc
In file included from src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc:8:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-04-11-2300/src/PhysicsTools/ONNXRuntime/interface/ONNXRuntime.h:19:10: fatal error: onnxruntime/onnxruntime_cxx_api.h: No such file or directory
   19 | #include "onnxruntime/onnxruntime_cxx_api.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
In file included from src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc:8:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-04-11-2300/src/PhysicsTools/ONNXRuntime/interface/ONNXRuntime.h:19:10: fatal error: onnxruntime/onnxruntime_cxx_api.h: No such file or directory


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Local Products Rules ..... started
>> Local Products Rules ..... done
>> Creating project symlinks
>> Entering Package PhysicsTools/ONNXRuntime
>> Compile sequence completed for CMSSW CMSSW_14_0_X_2024-04-11-2300
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-04-11-2300/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package PhysicsTools/ONNXRuntime
Entering library rule at PhysicsTools/ONNXRuntime
>> Compiling  src/PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants