Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Phase-2 T33 SIM LA payload #44350

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Mar 7, 2024

PR description:

The SIM version of the Phase-2 IT Lorentz Angle was somehow missed earlier, this PR adds that.

PR validation:

Test with 27234.0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport but needs to be backported to 14_0_X

attn: @mmusich

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Mar 7, 2024
@tvami
Copy link
Contributor Author

tvami commented Mar 7, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2024

cms-bot internal usage

@tvami
Copy link
Contributor Author

tvami commented Mar 7, 2024

@cmsbuild please test workflow 27234.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44350/39387

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2024

A new Pull Request was created by @tvami for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@consuegs, @cmsbuild, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@fabiocos, @missirol, @rsreds, @Martin-Grunewald, @mmusich, @yuanchao, @tocheng this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba191c/37972/summary.html
COMMIT: b1e22ef
CMSSW: CMSSW_14_1_X_2024-03-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44350/37972/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 58 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3391004
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3390978
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 207 log files, 169 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Mar 8, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants