Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of New Trigger Filter Bits for Muon POG NanoAOD #44347

Conversation

rbhattacharya04
Copy link
Contributor

This pull request is the backport of the pull request - #44345

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2024

A new Pull Request was created by @rbhattacharya04 for CMSSW_14_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @vlimant, @hqucms can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2024

cms-bot internal usage

@hqucms
Copy link
Contributor

hqucms commented Mar 7, 2024

enable nano

@hqucms
Copy link
Contributor

hqucms commented Mar 7, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea8411/37963/summary.html
COMMIT: 7f477ae
CMSSW: CMSSW_14_0_X_2024-03-07-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44347/37963/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16458
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16458
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 43 log files, 23 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.555 2.555 0.000 ( +0.0% ) 5.27 5.17 +2.0% 2.174 2.153
2500.001 2.705 2.705 0.000 ( +0.0% ) 4.60 4.65 -1.2% 2.592 2.120
2500.002 2.646 2.646 0.000 ( +0.0% ) 4.82 4.85 -0.5% 2.594 2.125
2500.01 1.326 1.326 0.000 ( +0.0% ) 9.46 9.65 -2.0% 2.242 2.069
2500.011 1.749 1.749 0.000 ( +0.0% ) 5.17 5.24 -1.4% 2.415 2.124
2500.012 1.590 1.590 0.000 ( +0.0% ) 7.38 7.57 -2.5% 2.350 2.144
2500.1 2.198 2.198 0.000 ( +0.0% ) 5.32 5.27 +0.9% 2.071 2.052
2500.2 2.314 2.314 0.000 ( +0.0% ) 6.07 6.11 -0.6% 1.904 1.943
2500.21 1.190 1.190 0.000 ( +0.0% ) 4.35 4.36 -0.2% 2.269 1.956
2500.211 1.554 1.554 0.000 ( +0.0% ) 3.61 3.75 -3.7% 2.234 2.057
2500.3 2.065 2.065 0.000 ( +0.0% ) 12.51 12.47 +0.3% 1.974 1.952
2500.301 2.639 2.639 0.000 ( +0.0% ) 9.98 10.10 -1.2% 1.959 1.959
2500.31 1.269 1.269 0.000 ( +0.0% ) 19.50 19.92 -2.1% 2.291 2.364
2500.311 1.643 1.643 0.000 ( +0.0% ) 11.74 12.73 -7.8% 2.339 2.453
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.32 1.36 -3.4% 1.700 1.699
2500.313 1.564 1.564 0.000 ( +0.0% ) 6.51 6.77 -3.9% 1.049 1.053
2500.314 1.165 1.165 0.000 ( +0.0% ) 12.16 13.58 -10.5% 2.051 1.835
2500.315 1.763 1.763 0.000 ( +0.0% ) 12.33 12.65 -2.6% 2.331 2.321
2500.4 2.065 2.065 0.000 ( +0.0% ) 12.15 12.76 -4.8% 1.869 1.876
2500.401 1.822 1.822 0.000 ( +0.0% ) 9.99 10.45 -4.5% 1.723 1.826
2500.402 2.639 2.639 0.000 ( +0.0% ) 9.33 9.95 -6.2% 1.853 1.911
2500.5 19.575 19.575 0.000 ( +0.0% ) 1.10 1.06 +3.5% 1.103 1.244

@hqucms
Copy link
Contributor

hqucms commented Mar 7, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

backport of #44345

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a499817 into cms-sw:CMSSW_14_0_X Mar 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants