ECAL - Fix heap-buffer overflows reported by ASAN - 140x

[thomreis]

PR description:

Fixes heap buffer overflows reported by ASAN (Issue #44275).
In addition also fix a copy and paste mistake where the EB conditions were used instead of the EE ones for gain 6 sample correlations.

PR validation:

Passes 12834.412 in CMSSW_14_1_ASAN_X_2024-02-28-2300.

Backport of #44301

[cmsbuild]

A new Pull Request was created by @thomreis for CMSSW_14_0_X.

It involves the following packages:

• RecoLocalCalo/EcalRecProducers (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@youyingli, @apsallid, @rchatter, @argiro, @wang0jin, @ReyerBand, @thomreis, @missirol this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from ECAL - Fix heap-buffer overflows reported by ASAN #44301

[cmsbuild]

cms-bot internal usage

[thomreis]

type bugfix

[thomreis]

type ecal

[thomreis]

enable gpu

[thomreis]

backport of #44301

[thomreis]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a07891/37888/summary.html
COMMIT: 8f0c5fd
CMSSW: CMSSW_14_0_X_2024-03-04-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44304/37888/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 8 lines from the logs
• Reco comparison results: 57 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3338820
• DQMHistoTests: Total failures: 1352
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3337446
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 11 differences found in the comparisons
• DQMHistoTests: Total files compared: 3
• DQMHistoTests: Total histograms compared: 39740
• DQMHistoTests: Total failures: 578
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 39162
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
• Checked 8 log files, 10 edm output root files, 3 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1

@cms-sw/reconstruction-l2

Please sign the master PR before the backport.

[rappoccio]

+1