Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Run4 MC GT with the updated OMTF config #44298

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Mar 4, 2024

PR description:

The mcRun4 global tags used for Phase 2 contain an obsolete OMTF configuration, taken from Run 2. The obsolete tag is L1TMuonOverlapParams_static_2016_mc. and it is changed here to L1TMuonOverlapParams_static_2023_mc. The newer configuration is already in use since a while for the most recent mcRun3 global tags.

Relevant cmsTalk with details is:

Modified tag:

  • L1TMuonOverlapParamsRcd: from L1TMuonOverlapParams_static_2016_mc to L1TMuonOverlapParams_static_2023_mc

Difference with respect to the previous run4 MC GT:

PR validation:

Successfully tested with the Run4 workflows in the short matrix

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

It can be backported to CMSSW_14_0_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

cms-bot internal usage

@perrotta
Copy link
Contributor Author

perrotta commented Mar 4, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44298/39317

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

A new Pull Request was created by @perrotta for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@consuegs, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@tocheng, @mmusich, @missirol, @yuanchao, @rsreds, @fabiocos, @Martin-Grunewald this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1eb0cd/37880/summary.html
COMMIT: 510faed
CMSSW: CMSSW_14_1_X_2024-03-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44298/37880/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 47 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3339090
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3339055
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor Author

perrotta commented Mar 4, 2024

+1

  • Modifications in L1T phase2 muons in the DT-CSC overlap region are compatible with the modified tag

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d5209dd into cms-sw:master Mar 5, 2024
11 checks passed
@perrotta perrotta deleted the updateL1tOmtfConfigInRun4Gt branch March 5, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants