Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Add ntuplization code for sagitta-bias studies to Alignment/OfflineValidation #44297

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 4, 2024

backport of #44282

PR description:

The goal of this PR is to add to the Alignment/OfflineValidation package a simple ntuplization code to do "sagitta bias" weak mode studies at CMS using di-muon resonant decays data as the ones in this set of slides.
The tool is not interlaced yet in the all-in-one meta-data tool, but might be included at a later time.
I have added the new analyzer to the standard battery of unit tests.

PR validation:

Run extensive private tests, also run successfully:

  • scram b runtests_Miscellanea
  • scram b runtests_testTrackAnalysis

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #44282 to the 2024 data-taking release.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@consuegs, @saumyaphor4252, @perrotta, @cmsbuild can you please review it and eventually sign? Thanks.
@rsreds, @yuanchao, @tocheng, @adewit, @mmusich, @tlampen this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Mar 4, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-109f56/37878/summary.html
COMMIT: 6937f90
CMSSW: CMSSW_14_0_X_2024-03-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44297/37878/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

perrotta commented Mar 6, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 81cb0a9 into cms-sw:CMSSW_14_0_X Mar 6, 2024
10 checks passed
@mmusich mmusich deleted the mm_dev_SagittaBiasNtupler_14_0_X branch March 6, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants