Dynamic PPS timing calibration fit [backport of 44235]

[grzanka]

PR description:

Extension to the existing calibration fit that calculates the parameter from the histogram, instead of relying on the pre-defined ranges. Logic works as follows:

Find the peak of counts in the TOT 1-d distribution (the peak must be located at TOT<20ns) -> this define the TOTMAX_bin
From TOTMAX_bin move to higher TOT till the counts are below THR% of max -> this define the upper_tot_range for the fit (in any case below 18 ns)
From TOTMAX_bin move to lower TOT till the counts are below THR% of max -> this define the lower_tot_range for the fit (in any case above 8ns)
Fit the 2d profile in the range (upper_tot_range, lower_tot_range)

PR validation:

Standard wfs for PPS timing calibration.

Backport of #44235

[cmsbuild]

A new Pull Request was created by @grzanka for CMSSW_14_0_X.

It involves the following packages:

• CalibPPS/TimingCalibration (alca)

@saumyaphor4252, @perrotta, @consuegs, @cmsbuild can you please review it and eventually sign? Thanks.
@tocheng, @fabferro, @yuanchao, @mmusich, @rsreds this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Dynamic pps timing calibration fit #44235

[cmsbuild]

cms-bot internal usage

[saumyaphor4252]

test parameters:

• workflows =1043.0,1044.0,1045.0

[saumyaphor4252]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a7c6c/37872/summary.html
COMMIT: 697f1a1
CMSSW: CMSSW_14_0_X_2024-03-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44289/37872/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 92 lines from the logs
• Reco comparison results: 50 differences found in the comparisons
• DQMHistoTests: Total files compared: 52
• DQMHistoTests: Total histograms compared: 3339926
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3339901
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
• Checked 217 log files, 169 edm output root files, 52 DQM output files
• TriggerResults: no differences found

[perrotta]

backport of #44235

[perrotta]

+1

• Verbatim backport of Dynamic pps timing calibration fit #44235
• Sccessfully merged in master since CMSSW_14_1_X_2024-03-01-2300

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1