[14_0_X] Fix logic in PFClusterSoAProducer kernels

[jsamudio]

PR description:

This PR fixes an issue with the clustering logic in PFClusterSoAProducer. The issue was highlighted by 2024 thresholds giving rise to topological clusters exceeding 100 seeds, which we had never naturally encountered in previous validations of the code in order to catch this flaw. The fall-back kernel was not being launched as intended in the previous logic, and is now changed to behave as intended.

PR validation:

For CPU-serial and GPU alpaka backends:
Validated QCDPU sample on 2022, 2023, and 2024 globalTag thresholds, and validated change in Pixel+ECAL+PF Alpaka HLT test workflow.

Cluster-level validation plots can be found here: https://hep.baylor.edu/jsamudio/fixLogic/

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #44273 for 14_0_X

@hatakeyamak @waredjeb @fwyzard @swagata87 @stahlleiton

[cmsbuild]

A new Pull Request was created by @jsamudio for CMSSW_14_0_X.

It involves the following packages:

• RecoParticleFlow/PFClusterProducer (reconstruction)

@cmsbuild, @mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@rovere, @hatakeyamak, @felicepantaleo, @seemasharmafnal, @missirol, @lgray, @sameasy, @mmarionncern this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix logic in PFClusterSoAProducer kernels #44273

[cmsbuild]

cms-bot internal usage

[hatakeyamak]

Maybe somebody can trigger jenkins? (not sure if test parameters will be inherited from the other PR #44273, or need to be redefined here)

[fwyzard]

type bugfix

[fwyzard]

backport #44273

[fwyzard]

urgent

for data taking

[fwyzard]

test parameters:

• enable = gpu
• workflows = 12434.422,12434.423,12434.424,12434.492
• workflows_gpu = 12434.422,12434.423,12434.424,12434.492
• workflow_opts = -w upgrade
• workflow_opts_gpu = -w upgrade

[fwyzard]

please test

[fwyzard]

allow @jsamudio test rights

(in case it needs to be updated and re-tested)

[swagata87]

type pf

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b38afa/37836/summary.html
COMMIT: 768c0d5
CMSSW: CMSSW_14_0_X_2024-02-29-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44278/37836/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 98 lines from the logs
• Reco comparison results: 45 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3407511
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3407484
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 215 log files, 181 edm output root files, 51 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 124 differences found in the comparisons
• DQMHistoTests: Total files compared: 6
• DQMHistoTests: Total histograms compared: 205801
• DQMHistoTests: Total failures: 1654
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 204147
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 5 files compared)
• Checked 23 log files, 30 edm output root files, 6 DQM output files
• TriggerResults: no differences found

[fwyzard]

assign heterogeneous

[fwyzard]

+heterogeneous

[cmsbuild]

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1

• Merging backport before master PR passes IB.