Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Tracker alignment offline validation tools: miscellaneous fixes to muon-related validations #44257

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 28, 2024

backport of #44252

PR description:

This PR contains a number of miscellaneous fixes / improvements in order to be able to run the Zmumu and DiMuonVertex tools in the tracker alignment all-in-one meta-tool, collecting feedback from users:

PR validation:

Run successfully the augmented unit tests via:

  • scram b runtests_Zmumuall
  • scram b runtests_DiMuonVall

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #44252 for 2024 data operations.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 28, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@cmsbuild, @perrotta, @consuegs, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@yuanchao, @rsreds, @tlampen, @mmusich, @tocheng, @adewit this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 28, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Feb 28, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-922e2b/37792/summary.html
COMMIT: 5446535
CMSSW: CMSSW_14_0_X_2024-02-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44257/37792/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

perrotta commented Mar 1, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Mar 4, 2024

@cms-sw/orp-l2 was there any particular reason to not include this PR in CMSSW_14_0_1? it was fully signed before the start of the built and the master version tested in IBs since at least 4 days.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e17a8af into cms-sw:CMSSW_14_0_X Mar 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants