Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex176E Update the rpc geometry description for 2024 scenario #44093

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Feb 27, 2024

PR description:

Update the RPC geometry description for the 2024 scenario

PR validation:

Use the overlap checking tool

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to CMSSW_14_0_X using #44094

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 27, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44093/39067

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • Geometry/MuonCommonData (geometry)

@bsunanda, @civanch, @mdhildreth, @Dr15Jones, @cmsbuild, @makortel can you please review it and eventually sign? Thanks.
@watson-ij, @ptcox, @slomeo, @fabiocos this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44093/39068

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #44093 was updated. @bsunanda, @makortel, @civanch, @mdhildreth, @Dr15Jones can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df6556/37704/summary.html
COMMIT: 9a0ed03
CMSSW: CMSSW_14_1_X_2024-02-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44093/37704/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@saumyaphor4252
Copy link
Contributor

urgent

@saumyaphor4252
Copy link
Contributor

FYI @cms-sw/alca-l2

@civanch
Copy link
Contributor

civanch commented Feb 27, 2024

+1

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44093/39279

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

Pull request #44093 was updated. @civanch, @makortel, @mdhildreth, @Dr15Jones, @bsunanda can you please check and sign again.

@bsunanda
Copy link
Contributor Author

+geometry

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df6556/37806/summary.html
COMMIT: f55d978
CMSSW: CMSSW_14_1_X_2024-02-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44093/37806/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 42 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3338784
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338753
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e08fb2e into cms-sw:master Feb 29, 2024
11 checks passed
cmsbuild added a commit that referenced this pull request Feb 29, 2024
Run3-gex176F Backport the correction to 2024 Geometry to CMSSW_14_0_X due to RPC detector (backport of #44065 and #44093)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants