Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PPS] Added gtStage2DigisAlCaRecoProducer to ALCARECOPRODUCER [14_0_X backport] #44091

Conversation

grzanka
Copy link
Contributor

@grzanka grzanka commented Feb 26, 2024

PR description:

This is backport of #44044

The PR adds the hltGtStage2Digis production step in the PPS ALCARECO sequence and preserves this product in the output. This change follows the discussion in CMSHLT-2989, in which the the hltFEDSelectorL1 products are added to the HLT output in order to have access to the prescale values in the final dataset.

commit 35a0252
Author: Leszek Grzanka <[email protected]>
Date:   Sat Feb 24 18:27:48 2024 +0100

    silencing logs in the relvals; unit test refreshed

commit 5bef250
Author: Leszek Grzanka <[email protected]>
Date:   Sat Feb 24 15:42:54 2024 +0100

    Update Calibration/PPSAlCaRecoProducer/test/test_prompt_AlCaRecoProducer.sh

    Co-authored-by: Marco Musich <[email protected]>

commit 58b9a76
Author: Leszek Grzanka <[email protected]>
Date:   Sat Feb 24 14:25:30 2024 +0100

    Update Calibration/PPSAlCaRecoProducer/test/test_express_AlCaRecoProducer.sh

    Co-authored-by: Marco Musich <[email protected]>

commit 671fafa
Author: Leszek Grzanka <[email protected]>
Date:   Thu Feb 22 21:26:37 2024 +0100

    renaming gtStage2Digis according to PR review; unit test refreshed

commit b031e8e
Merge: ca93802 e15c1e3
Author: Leszek Grzanka <[email protected]>
Date:   Tue Feb 20 15:31:37 2024 +0100

    Merged CMSSW_14_1_X_feature_hltGtStage2Digis_in_ALCARECO from repository CTPPS with cms-merge-topic

commit e15c1e3
Author: abellora <[email protected]>
Date:   Thu Feb 15 15:02:18 2024 +0100

    Added hltGtStage2Digis to seqALCARECOPPSCalMaxTracksReco

Co-authored-by: Leszek Grzanka <[email protected]>
Co-authored-by: Marco Musich <[email protected]>
Co-authored-by: abellora <[email protected]>
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 26, 2024

A new Pull Request was created by @grzanka for CMSSW_14_0_X.

It involves the following packages:

  • Calibration/PPSAlCaRecoProducer (alca)
  • Configuration/PyReleaseValidation (pdmv, upgrade)

@sunilUIET, @consuegs, @miquork, @cmsbuild, @subirsarkar, @srimanob, @perrotta, @AdrianoDee, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@yuanchao, @rsreds, @fabiocos, @Martin-Grunewald, @missirol, @mmusich, @tocheng, @slomeo, @makortel this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 26, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor

mmusich commented Feb 26, 2024

type ctpps

@cmsbuild cmsbuild added the ctpps label Feb 26, 2024
@mmusich
Copy link
Contributor

mmusich commented Feb 26, 2024

backport of #44044

@mmusich
Copy link
Contributor

mmusich commented Feb 26, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee952d/37702/summary.html
COMMIT: 9d3aee0
CMSSW: CMSSW_14_0_X_2024-02-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44091/37702/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@vavati
Copy link

vavati commented Mar 4, 2024

Is there anything else PPS needs to do to get this PR merged ?

@perrotta
Copy link
Contributor

perrotta commented Mar 4, 2024

Is there anything else PPS needs to do to get this PR merged ?

The master PR should be merged first, hopefully today (as it s fully signed)

@grzanka
Copy link
Contributor Author

grzanka commented Mar 5, 2024

Is there anything else PPS needs to do to get this PR merged ?

The master PR should be merged first, hopefully today (as it s fully signed)

Master PR is merged #44044 , I hope this PR can proceed with merging as well.
It's important for us to include it for data taking.

@mmusich
Copy link
Contributor

mmusich commented Mar 5, 2024

urgent

@cmsbuild cmsbuild added the urgent label Mar 5, 2024
@perrotta
Copy link
Contributor

perrotta commented Mar 5, 2024

+1

@srimanob
Copy link
Contributor

srimanob commented Mar 5, 2024

+Upgrade

@perrotta
Copy link
Contributor

perrotta commented Mar 5, 2024

@cms-sw/pdmv-l2 please sign

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0d98914 into cms-sw:CMSSW_14_0_X Mar 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants