Correct the FindClus block size

[fwyzard]

PR description:

Compute the FindClus block size from the maximum number of hits per module, and harmonise the block size used for the kernel launch and inside the kernel itself.

PR validation:

Fixes #44077.

[cmsbuild]

cms-bot internal usage

[fwyzard]

type bugfix

[fwyzard]

enable gpu

[fwyzard]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44081/39048

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/PixelClustering.h modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
  • File RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/SiPixelRawToClusterKernel.dev.cc modified in PR(s): Fix on muon_mvaID in NanoAOD #43976

[cmsbuild]

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

• RecoLocalTracker/SiPixelClusterizer (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@tvami, @mtosi, @mroguljic, @rovere, @gpetruc, @threus, @JanFSchulte, @missirol, @ferencek, @VinInn, @dkotlins, @felicepantaleo, @mmusich, @GiacomoSguazzoni, @VourMa this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd62dc/37679/summary.html
COMMIT: 88ac527
CMSSW: CMSSW_14_1_X_2024-02-25-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44081/37679/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 8 lines from the logs
• Reco comparison results: 57 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3245365
• DQMHistoTests: Total failures: 1186
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3244157
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 32 differences found in the comparisons
• DQMHistoTests: Total files compared: 3
• DQMHistoTests: Total histograms compared: 39740
• DQMHistoTests: Total failures: 749
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 38991
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
• Checked 8 log files, 10 edm output root files, 3 DQM output files
• TriggerResults: no differences found

[fwyzard]

urgent

for 2024 data taking

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1