Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Updates for 2024 Wfs (PR Testing, IBs, Patatrack, inputs) #44076

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

AdrianoDee
Copy link
Contributor

This PR updates the wfs used in PR testing, IB test (standard and GPU). It includes f77b3b3 from @mmusich.

For the moment the 2023 wfs are kept as they are with the idea of reducing them later this year.

The default input GEN-SIM datasets for 2024 conditions are updated to 14_0_0_pre3 RelVals.

backport of #44075

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 25, 2024

A new Pull Request was created by @AdrianoDee for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@miquork, @sunilUIET, @cmsbuild, @subirsarkar, @srimanob, @AdrianoDee can you please review it and eventually sign? Thanks.
@fabiocos, @Martin-Grunewald, @makortel, @slomeo, @missirol this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 25, 2024

cms-bot internal usage

@AdrianoDee
Copy link
Contributor Author

enable gpu

@AdrianoDee
Copy link
Contributor Author

please test

@AdrianoDee
Copy link
Contributor Author

backport of #44075

@cmsbuild
Copy link
Contributor

Pull request #44076 was updated. @cmsbuild, @miquork, @AdrianoDee, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again.

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c567b/37666/summary.html
COMMIT: 30d767d
CMSSW: CMSSW_14_0_X_2024-02-25-0000/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44076/37666/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

RelVals-INPUT

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 22 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 1047
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 38693
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

Pull request #44076 was updated. @cmsbuild, @sunilUIET, @subirsarkar, @miquork, @AdrianoDee, @srimanob can you please check and sign again.

@AdrianoDee
Copy link
Contributor Author

code-checks

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44076/39046

  • This PR adds an extra 88KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c567b/37675/summary.html
COMMIT: 1b1e5e1
CMSSW: CMSSW_14_0_X_2024-02-25-0000/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44076/37675/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 42 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 2756270
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2756248
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 187 log files, 146 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 642
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 39098
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

REMINDER @antoniovilela, @sextonkennedy, @rappoccio: This PR was tested with #44027, please check if they should be merged together

@AdrianoDee
Copy link
Contributor Author

+pdmv

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c2b76cc into cms-sw:CMSSW_14_0_X Feb 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants