[14.0.X] Remove unnecessary ESProducer from LegacyPFClusterProducer #44071

jsamudio · 2024-02-24T06:30:29Z

PR description:

This PR removes pfClusterParamsESProducer from LegacyPFClusterProducer as it is not used in the producer. Configurations for offline workflows and customizeHLTforAlpaka.py are updated to reflect this change.

PR validation:

Tested on workflow 12434.423 which uses the HLT customization and HCAL only configuration for this producer.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #44070 to 14_0_X

@hatakeyamak @fwyzard @waredjeb

cmsbuild · 2024-02-24T06:30:54Z

A new Pull Request was created by @jsamudio for CMSSW_14_0_X.

It involves the following packages:

HLTrigger/Configuration (hlt)
RecoParticleFlow/PFClusterProducer (reconstruction)

@jfernan2, @mmusich, @Martin-Grunewald, @cmsbuild, @mandrenguyen can you please review it and eventually sign? Thanks.
@missirol, @mmarionncern, @seemasharmafnal, @Martin-Grunewald, @lgray, @rovere, @silviodonato, @hatakeyamak, @sameasy, @felicepantaleo this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

Backported from Remove unnecessary ESProducer from LegacyPFClusterProducer #44070

cmsbuild · 2024-02-24T06:30:55Z

cms-bot internal usage

Martin-Grunewald · 2024-02-24T06:49:49Z

please test

mmusich · 2024-02-24T06:50:38Z

@cmsbuild please abort

mmusich · 2024-02-24T06:50:48Z

enable gpu

mmusich · 2024-02-24T06:51:32Z

test parameters:

workflow_opts_gpu= -w upgrade
workflows_gpu = 12434.423

mmusich · 2024-02-24T06:51:47Z

@cmsbuild, please test

cmsbuild · 2024-02-24T09:59:02Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17af4a/37648/summary.html
COMMIT: d15ff66
CMSSW: CMSSW_14_0_X_2024-02-23-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44071/37648/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 12 lines from the logs
Reco comparison results: 62 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3245401
DQMHistoTests: Total failures: 1189
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3244190
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 35 differences found in the comparisons
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 40949
DQMHistoTests: Total failures: 1784
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 39165
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
Checked 12 log files, 15 edm output root files, 4 DQM output files
TriggerResults: no differences found

mmusich · 2024-02-27T07:32:44Z

RecoParticleFlow/PFClusterProducer/plugins/LegacyPFClusterProducer.cc

@@ -68,7 +66,6 @@ class LegacyPFClusterProducer : public edm::stream::EDProducer<> {
    edm::ParameterSetDescription desc;
    desc.add<edm::InputTag>("src");
    desc.add<edm::InputTag>("PFRecHitsLabelIn");
-    desc.add<edm::ESInputTag>("pfClusterParams");


see https://github.com/cms-sw/cmssw/pull/44070/files#r1503759168

mmusich · 2024-02-27T07:32:53Z

type pf

cmsbuild · 2024-02-27T18:00:37Z

Pull request #44071 was updated. @mmusich, @jfernan2, @Martin-Grunewald, @cmsbuild, @mandrenguyen can you please check and sign again.

mmusich · 2024-02-27T18:18:10Z

@cmsbuild, please test

cmsbuild · 2024-02-28T10:19:35Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17af4a/37755/summary.html
COMMIT: 6df8b30
CMSSW: CMSSW_14_0_X_2024-02-27-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44071/37755/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 74 lines to the logs
Reco comparison results: 54 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3245401
DQMHistoTests: Total failures: 1186
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3244193
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 35 differences found in the comparisons
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 40949
DQMHistoTests: Total failures: 1415
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 39534
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
Checked 12 log files, 15 edm output root files, 4 DQM output files
TriggerResults: no differences found

mmusich · 2024-02-28T10:25:05Z

+hlt

PR according to description and follow-up review;
test workflows with alpaka customization run fine: [14.0.X] Remove unnecessary ESProducer from LegacyPFClusterProducer #44071 (comment)
6df8b30 introduces some missing defaults in the LegacyPFClusterProducer::fillDescriptions method to allow parsing in confDB.

mmusich · 2024-02-28T10:25:27Z

urgent

please consider this for the next 14_0_1 build

jfernan2 · 2024-02-28T12:10:54Z

+1

cmsbuild · 2024-02-28T12:11:13Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

mmusich · 2024-02-28T14:18:52Z

urgent

to enter the next 14_0_X release

mmusich · 2024-02-29T08:40:17Z

backport of #44070

antoniovilela · 2024-02-29T10:50:21Z

+1

Merging backport before IB test in master.

Remove unnecessary parameters from LegacyPFClusterProducer

d15ff66

cmsbuild added this to the CMSSW_14_0_X milestone Feb 24, 2024

cmsbuild added reconstruction-pending hlt-pending pending-signatures tests-pending orp-pending labels Feb 24, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 24, 2024

cmsbuild added tests-pending and removed tests-started labels Feb 24, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 24, 2024

cmsbuild added tests-approved and removed tests-started labels Feb 24, 2024

mmusich reviewed Feb 27, 2024

View reviewed changes

cmsbuild added the pf label Feb 27, 2024

Add default InputTags in fillDescriptions

6df8b30

cmsbuild added tests-pending and removed tests-approved labels Feb 27, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 27, 2024

cmsbuild added tests-approved and removed tests-started labels Feb 28, 2024

cmsbuild added hlt-approved urgent and removed hlt-pending labels Feb 28, 2024

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Feb 28, 2024

cmsbuild added the backport label Feb 29, 2024

cmsbuild added orp-approved and removed orp-pending labels Feb 29, 2024

cmsbuild merged commit a0c34ad into cms-sw:CMSSW_14_0_X Feb 29, 2024
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0.X] Remove unnecessary ESProducer from LegacyPFClusterProducer #44071

[14.0.X] Remove unnecessary ESProducer from LegacyPFClusterProducer #44071

jsamudio commented Feb 24, 2024

cmsbuild commented Feb 24, 2024 •

edited

Loading

cmsbuild commented Feb 24, 2024 •

edited

Loading

Martin-Grunewald commented Feb 24, 2024

mmusich commented Feb 24, 2024

mmusich commented Feb 24, 2024

mmusich commented Feb 24, 2024

mmusich commented Feb 24, 2024

cmsbuild commented Feb 24, 2024

mmusich Feb 27, 2024

mmusich commented Feb 27, 2024

cmsbuild commented Feb 27, 2024

mmusich commented Feb 27, 2024

cmsbuild commented Feb 28, 2024

mmusich commented Feb 28, 2024

mmusich commented Feb 28, 2024

jfernan2 commented Feb 28, 2024

cmsbuild commented Feb 28, 2024

mmusich commented Feb 28, 2024

mmusich commented Feb 29, 2024

antoniovilela commented Feb 29, 2024

[14.0.X] Remove unnecessary ESProducer from LegacyPFClusterProducer #44071

[14.0.X] Remove unnecessary ESProducer from LegacyPFClusterProducer #44071

Conversation

jsamudio commented Feb 24, 2024

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Feb 24, 2024 • edited Loading

cmsbuild commented Feb 24, 2024 • edited Loading

Martin-Grunewald commented Feb 24, 2024

mmusich commented Feb 24, 2024

mmusich commented Feb 24, 2024

mmusich commented Feb 24, 2024

mmusich commented Feb 24, 2024

cmsbuild commented Feb 24, 2024

Comparison Summary

GPU Comparison Summary

mmusich Feb 27, 2024

Choose a reason for hiding this comment

mmusich commented Feb 27, 2024

cmsbuild commented Feb 27, 2024

mmusich commented Feb 27, 2024

cmsbuild commented Feb 28, 2024

Comparison Summary

GPU Comparison Summary

mmusich commented Feb 28, 2024

mmusich commented Feb 28, 2024

jfernan2 commented Feb 28, 2024

cmsbuild commented Feb 28, 2024

mmusich commented Feb 28, 2024

mmusich commented Feb 29, 2024

antoniovilela commented Feb 29, 2024

cmsbuild commented Feb 24, 2024 •

edited

Loading

cmsbuild commented Feb 24, 2024 •

edited

Loading