Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex176D Modify the RPC numbering scheme to avoid wrong DetId assignment #44065

Merged
merged 2 commits into from
Feb 26, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Configuration/Geometry/python/dict2021Geometry.py
Original file line number Diff line number Diff line change
@@ -1497,7 +1497,7 @@
'Geometry/MuonCommonData/data/mfshield/2017/v2/mfshield.xml',
],
2 : [
'Geometry/MuonCommonData/data/muonNumbering/2021/v5/muonNumbering.xml',
'Geometry/MuonCommonData/data/muonNumbering/2021/v6/muonNumbering.xml',
],
3 : [
'Geometry/MuonSimData/data/muonSens/2021/v4/muonSens.xml',
Original file line number Diff line number Diff line change
@@ -249,7 +249,7 @@
<Include ref='Geometry/MuonCommonData/data/gem21/2024/v1/gem21.xml'/>
<Include ref='Geometry/MuonCommonData/data/csc/2021/v3/csc.xml'/>
<Include ref='Geometry/MuonCommonData/data/mfshield/2017/v2/mfshield.xml'/>
<Include ref='Geometry/MuonCommonData/data/muonNumbering/2021/v5/muonNumbering.xml'/>
<Include ref='Geometry/MuonCommonData/data/muonNumbering/2021/v6/muonNumbering.xml'/>
<Include ref='Geometry/ForwardCommonData/data/forward/2021/v1/forward.xml'/>
<Include ref='Geometry/ForwardCommonData/data/totemt2/2021/v1/totemt2.xml'/>
<Include ref='Geometry/ForwardCommonData/data/forwardshield/2021/v1/forwardshield.xml'/>
Original file line number Diff line number Diff line change
@@ -249,7 +249,7 @@
<Include ref='Geometry/MuonCommonData/data/gem21/2024/v1/gem21.xml'/>
<Include ref='Geometry/MuonCommonData/data/csc/2021/v3/csc.xml'/>
<Include ref='Geometry/MuonCommonData/data/mfshield/2017/v2/mfshield.xml'/>
<Include ref='Geometry/MuonCommonData/data/muonNumbering/2021/v5/muonNumbering.xml'/>
<Include ref='Geometry/MuonCommonData/data/muonNumbering/2021/v6/muonNumbering.xml'/>
<Include ref='Geometry/ForwardCommonData/data/forward/2021/v1/forward.xml'/>
<Include ref='Geometry/ForwardCommonData/data/totemt2/2021/v1/totemt2.xml'/>
<Include ref='Geometry/ForwardCommonData/data/forwardshield/2021/v1/forwardshield.xml'/>
Original file line number Diff line number Diff line change
@@ -249,7 +249,7 @@
<Include ref='Geometry/MuonCommonData/data/gem21/2024/v1/gem21.xml'/>
<Include ref='Geometry/MuonCommonData/data/csc/2021/v3/csc.xml'/>
<Include ref='Geometry/MuonCommonData/data/mfshield/2017/v2/mfshield.xml'/>
<Include ref='Geometry/MuonCommonData/data/muonNumbering/2021/v5/muonNumbering.xml'/>
<Include ref='Geometry/MuonCommonData/data/muonNumbering/2021/v6/muonNumbering.xml'/>
<Include ref='Geometry/ForwardCommonData/data/forward/2021/v1/forward.xml'/>
<Include ref='Geometry/ForwardCommonData/data/totemt2/2021/v1/totemt2.xml'/>
<Include ref='Geometry/ForwardCommonData/data/forwardshield/2021/v1/forwardshield.xml'/>
Original file line number Diff line number Diff line change
@@ -249,7 +249,7 @@
<Include ref='Geometry/MuonCommonData/data/gem21/2024/v1/gem21.xml'/>
<Include ref='Geometry/MuonCommonData/data/csc/2021/v3/csc.xml'/>
<Include ref='Geometry/MuonCommonData/data/mfshield/2017/v2/mfshield.xml'/>
<Include ref='Geometry/MuonCommonData/data/muonNumbering/2021/v5/muonNumbering.xml'/>
<Include ref='Geometry/MuonCommonData/data/muonNumbering/2021/v6/muonNumbering.xml'/>
<Include ref='Geometry/ForwardCommonData/data/forward/2021/v1/forward.xml'/>
<Include ref='Geometry/ForwardCommonData/data/totemt2/2021/v1/totemt2.xml'/>
<Include ref='Geometry/ForwardCommonData/data/forwardshield/2021/v1/forwardshield.xml'/>
Original file line number Diff line number Diff line change
@@ -249,7 +249,7 @@
<Include ref='Geometry/MuonCommonData/data/gem21/2024/v1/gem21.xml'/>
<Include ref='Geometry/MuonCommonData/data/csc/2021/v3/csc.xml'/>
<Include ref='Geometry/MuonCommonData/data/mfshield/2017/v2/mfshield.xml'/>
<Include ref='Geometry/MuonCommonData/data/muonNumbering/2021/v5/muonNumbering.xml'/>
<Include ref='Geometry/MuonCommonData/data/muonNumbering/2021/v6/muonNumbering.xml'/>
<Include ref='Geometry/ForwardCommonData/data/forward/2021/v1/forward.xml'/>
<Include ref='Geometry/ForwardCommonData/data/totemt2/2021/v1/totemt2.xml'/>
<Include ref='Geometry/ForwardCommonData/data/forwardshield/2021/v1/forwardshield.xml'/>
Original file line number Diff line number Diff line change
@@ -249,7 +249,7 @@
<Include ref='Geometry/MuonCommonData/data/gem21/2024/v1/gem21.xml'/>
<Include ref='Geometry/MuonCommonData/data/csc/2021/v3/csc.xml'/>
<Include ref='Geometry/MuonCommonData/data/mfshield/2017/v2/mfshield.xml'/>
<Include ref='Geometry/MuonCommonData/data/muonNumbering/2021/v5/muonNumbering.xml'/>
<Include ref='Geometry/MuonCommonData/data/muonNumbering/2021/v6/muonNumbering.xml'/>
<Include ref='Geometry/ForwardCommonData/data/forward/2021/v1/forward.xml'/>
<Include ref='Geometry/ForwardCommonData/data/totemt2/2021/v1/totemt2.xml'/>
<Include ref='Geometry/ForwardCommonData/data/forwardshield/2021/v1/forwardshield.xml'/>
Original file line number Diff line number Diff line change
@@ -252,7 +252,7 @@
'Geometry/MuonCommonData/data/mfshield/2017/v2/mfshield.xml',
)+
cms.vstring(
'Geometry/MuonCommonData/data/muonNumbering/2021/v5/muonNumbering.xml',
'Geometry/MuonCommonData/data/muonNumbering/2021/v6/muonNumbering.xml',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda , why not ...../muonNumbering/2024/v1/muonNumbering.xml ?

'Geometry/ForwardCommonData/data/forward/2021/v1/forward.xml',
'Geometry/ForwardCommonData/data/totemt2/2021/v1/totemt2.xml',
'Geometry/ForwardCommonData/data/forwardshield/2021/v1/forwardshield.xml',
Original file line number Diff line number Diff line change
@@ -252,7 +252,7 @@
'Geometry/MuonCommonData/data/mfshield/2017/v2/mfshield.xml',
)+
cms.vstring(
'Geometry/MuonCommonData/data/muonNumbering/2021/v5/muonNumbering.xml',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda , are you sure if we need this file? For me would be OK if these type of files are changed only for Run-3 legacy.

'Geometry/MuonCommonData/data/muonNumbering/2021/v6/muonNumbering.xml',
'Geometry/ForwardCommonData/data/forward/2021/v1/forward.xml',
'Geometry/ForwardCommonData/data/totemt2/2021/v1/totemt2.xml',
'Geometry/ForwardCommonData/data/forwardshield/2021/v1/forwardshield.xml',
Original file line number Diff line number Diff line change
@@ -252,7 +252,7 @@
'Geometry/MuonCommonData/data/mfshield/2017/v2/mfshield.xml',
)+
cms.vstring(
'Geometry/MuonCommonData/data/muonNumbering/2021/v5/muonNumbering.xml',
'Geometry/MuonCommonData/data/muonNumbering/2021/v6/muonNumbering.xml',
'Geometry/ForwardCommonData/data/forward/2021/v1/forward.xml',
'Geometry/ForwardCommonData/data/totemt2/2021/v1/totemt2.xml',
'Geometry/ForwardCommonData/data/forwardshield/2021/v1/forwardshield.xml',
Original file line number Diff line number Diff line change
@@ -252,7 +252,7 @@
'Geometry/MuonCommonData/data/mfshield/2017/v2/mfshield.xml',
)+
cms.vstring(
'Geometry/MuonCommonData/data/muonNumbering/2021/v5/muonNumbering.xml',
'Geometry/MuonCommonData/data/muonNumbering/2021/v6/muonNumbering.xml',
'Geometry/ForwardCommonData/data/forward/2021/v1/forward.xml',
'Geometry/ForwardCommonData/data/totemt2/2021/v1/totemt2.xml',
'Geometry/ForwardCommonData/data/forwardshield/2021/v1/forwardshield.xml',
Original file line number Diff line number Diff line change
@@ -252,7 +252,7 @@
'Geometry/MuonCommonData/data/mfshield/2017/v2/mfshield.xml',
)+
cms.vstring(
'Geometry/MuonCommonData/data/muonNumbering/2021/v5/muonNumbering.xml',
'Geometry/MuonCommonData/data/muonNumbering/2021/v6/muonNumbering.xml',
'Geometry/ForwardCommonData/data/forward/2021/v1/forward.xml',
'Geometry/ForwardCommonData/data/totemt2/2021/v1/totemt2.xml',
'Geometry/ForwardCommonData/data/forwardshield/2021/v1/forwardshield.xml',
Original file line number Diff line number Diff line change
@@ -252,7 +252,7 @@
'Geometry/MuonCommonData/data/mfshield/2017/v2/mfshield.xml',
)+
cms.vstring(
'Geometry/MuonCommonData/data/muonNumbering/2021/v5/muonNumbering.xml',
'Geometry/MuonCommonData/data/muonNumbering/2021/v6/muonNumbering.xml',
'Geometry/ForwardCommonData/data/forward/2021/v1/forward.xml',
'Geometry/ForwardCommonData/data/totemt2/2021/v1/totemt2.xml',
'Geometry/ForwardCommonData/data/forwardshield/2021/v1/forwardshield.xml',
504 changes: 504 additions & 0 deletions Geometry/MuonCommonData/data/muonNumbering/2021/v6/muonNumbering.xml

Large diffs are not rendered by default.