Migrate away from OwnVector<TrackingRegion>

[wddgit]

PR description:

This is part of a campaign to remove code related to OwnVector. This is in preparation for a possible move to RNTuple from TTree as a persistence mechanism. RNTuple does not support OwnVector because it allows polymorphism. Issue #42734 discusses this in more detail.

In this PR, OwnVector<TrackingRegion> is replaced by std::vector<std::unique_ptr<TrackingRegion>>. This is one of the classes on Matti's list in the issue.

The dictionaries are transient so there should be no backward compatibility issues.

The output and behavior of the code should be the same as before. There is one producer and 4 modules that consume the product.

(The code-format utility also modified the spacing in a few lines...)

PR validation:

runTheMatrix.py executes most of the modifed code. Test 25.0 runs the producer and 2 of the modules that consume the product. Test 5.1 executes the FastSimulation module that consumes the product and the producer. TrajectorySeedProducer seems to be only run by HLT configurations, but I temporarily forced it to run in test 25.0 (just manually added it). I verified all those tests successfully get past the point where Event::get is called and its succeeds getting the product put by the producer. All the runTheMatrix "limited" tests pass.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44063/39009

• This PR adds an extra 48KB to repository

[cmsbuild]

A new Pull Request was created by @wddgit for master.

It involves the following packages:

• DQM/TrackingMonitor (dqm)
• FastSimulation/Tracking (fastsim)
• RecoTracker/FinalTrackSelectors (reconstruction)
• RecoTracker/TkHitPairs (reconstruction)
• RecoTracker/TkTrackingRegions (reconstruction)

@rvenditti, @mandrenguyen, @tjavaid, @nothingface0, @sbein, @ssekmen, @syuvivida, @jfernan2, @mdhildreth, @civanch, @cmsbuild, @antoniovagnerini can you please review it and eventually sign? Thanks.
@missirol, @gpetruc, @fioriNTU, @arossi83, @mtosi, @rovere, @GiacomoSguazzoni, @mmusich, @idebruyn, @VinInn, @dgulhan, @VourMa, @threus, @matt-komm, @sroychow, @jandrea, @felicepantaleo, @JanFSchulte this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[wddgit]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce24bb/37632/summary.html
COMMIT: f2ac2b8
CMSSW: CMSSW_14_1_X_2024-02-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44063/37632/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 6 lines to the logs
• Reco comparison results: 53 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3245365
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3245334
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[civanch]

+1

this is a technical PR

[tjavaid]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1