Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[ROOT6] RPageSinkFile is now in ROOT::Experimental::Internal namespace" #44057

Merged

Conversation

iarspider
Copy link
Contributor

Reverts #44032 - ROOT update cms-sw/cmsdist#9025 should be merged first

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 22, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44057/38997

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@vlimant, @hqucms, @cmsbuild can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

please test for CMSSW_14_1_ROOT6_X

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed2548/37623/summary.html
COMMIT: 3fd2023
CMSSW: CMSSW_14_1_ROOT6_X_2024-02-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44057/37623/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@vlimant
Copy link
Contributor

vlimant commented Feb 26, 2024

+1
technical

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 71be349 into cms-sw:master Feb 26, 2024
10 checks passed
@iarspider iarspider deleted the revert-44032-move-RPageSinkFile branch February 27, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants