Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring HLT Phase2 simplified timing menu variant up to date. #44041

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Feb 21, 2024

PR description:

Sibling of #44025 to circumvent the bot's caching limits.

Tests with this PR alone will fail. This PR should always be tested together with its sister #44025.

PR validation:

See #44025

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 21, 2024

cms-bot internal usage

@rovere
Copy link
Contributor Author

rovere commented Feb 21, 2024

@cmsbuild please test with #44025

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44041/38980

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rovere for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @missirol, @silviodonato this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-85218a/37598/summary.html
COMMIT: 418ee0c
CMSSW: CMSSW_14_1_X_2024-02-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44041/37598/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 136.806136.806_RunDoubleMuon2017D/step2_RunDoubleMuon2017D.log

Comparison Summary

Summary:

  • You potentially added 32 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 141 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248389
  • DQMHistoTests: Total failures: 24
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248343
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 19.69 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 24834.0,... ): 3.938 KiB HLT/Muon
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 5 / 46 workflows

@rovere
Copy link
Contributor Author

rovere commented Feb 23, 2024

  • The failure seems to be independent from this PR.
  • All plots/variables referring to hfprereco, hfreco, and horeco are responsible for differences since those collections have been renamed with hlt in front, trying to adopt the same convention everywhere in the menu.
  • The differences in triggerResults are difficult to judge/understand.

@mmusich
Copy link
Contributor

mmusich commented Feb 23, 2024

test parameters:

@rovere
Copy link
Contributor Author

rovere commented Feb 23, 2024

@mmusich I'm not sure what the effect or your last command to the bot should be ...?

@mmusich
Copy link
Contributor

mmusich commented Feb 23, 2024

I'm not sure what the effect or your last command to the bot should be ...?

none, but if we re-test, we don't need to specify "with 44025". Also unless someone clears the bot instruction it will guarantee this remains as flagged as a dependent PR (which is mandatory for ORP to comply with when merging).

@mmusich
Copy link
Contributor

mmusich commented Feb 23, 2024

@cmsbuild, please test

  • just to remove the failure

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-85218a/37635/summary.html
COMMIT: 418ee0c
CMSSW: CMSSW_14_1_X_2024-02-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44041/37635/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 15 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 140 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3245365
  • DQMHistoTests: Total failures: 21
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3245322
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 19.69 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 24834.0,... ): 3.938 KiB HLT/Muon
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 5 / 46 workflows

@rovere rovere changed the title [RFC] Bring HLT Phase2 simplified timing menu variant up to date. Bring HLT Phase2 simplified timing menu variant up to date. Mar 5, 2024
@rovere
Copy link
Contributor Author

rovere commented Mar 5, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-85218a/37907/summary.html
COMMIT: 418ee0c
CMSSW: CMSSW_14_1_X_2024-03-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44041/37907/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 27 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 149 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3339090
  • DQMHistoTests: Total failures: 1373
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3337695
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 19.69 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 24834.0,... ): 3.938 KiB HLT/Muon
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 5 / 47 workflows

@mmusich
Copy link
Contributor

mmusich commented Mar 7, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-85218a/37974/summary.html
COMMIT: 418ee0c
CMSSW: CMSSW_14_1_X_2024-03-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44041/37974/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 29 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 187 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3293428
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3293399
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 5 / 46 workflows

@mmusich
Copy link
Contributor

mmusich commented Mar 8, 2024

+hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #44025

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants