Adding ZDC packer

[matt2275]

PR description:

Adding a ZDC packer to EventFilter/L1TRawtoDigi

Only output change should be L1TDigitoRaw now can include EtSumZDC info.

PR has no dependencies

PR validation:

PR tested with EventFilter/L1TRawtoDigi/test/test_RawToDigiToRawToDigi_GT_cfi.py where the output produces 2 sets of data:

1. Raw Dataunpacked to Digis
2. Raw Data unpacked to Digis then repacked and unpacked again

These 2 data sets were compared and were identical for EtSumZDC data.

I attached the summary of the RunTheMatrix test where there were some failures
RunTheMatrixSummary.txt

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44019/38948

• This PR adds an extra 28KB to repository

• Found files with invalid states:

  • EventFilter/L1TRawToDigi/test/test_RawToDigiToRaw_GT.py:
    • Added: 8c156dd
    • Deleted: 11bb556

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44019/38948/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44019/38948/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[missirol]

@matt2275 , please fix the code-format issues using scram build code-format as described above.

Just for my own understanding: does this PR as is take care of introducing all we need to re-emulate ZDC in the L1REPACK step ? Or, do we need any changes to files like the following ones ?
https://github.com/cms-sw/cmssw/blob/master/Configuration/StandardSequences/python/SimL1EmulatorRepack_Full_cff.py
https://github.com/cms-sw/cmssw/blob/master/Configuration/StandardSequences/python/SimL1EmulatorRepack_FullMC_cff.py
https://github.com/cms-sw/cmssw/blob/master/Configuration/StandardSequences/python/SimL1EmulatorRepack_FullSimTP_cff.py

FYI: @cms-sw/l1-l2 @cms-sw/hlt-l2

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44019/38965

• This PR adds an extra 32KB to repository

• Found files with invalid states:

  • EventFilter/L1TRawToDigi/test/test_RawToDigiToRaw_GT.py:
    • Added: 8c156dd
    • Deleted: 11bb556

[cmsbuild]

A new Pull Request was created by @matt2275 for master.

It involves the following packages:

• EventFilter/L1TRawToDigi (l1)

@cmsbuild, @aloeliger, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @dinyar, @thomreis, @missirol, @eyigitba this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[matt2275]

@missirol, I don't believe there is a L1 ZDC simulation yet so I don't think those files should be changed at the moment but I'm not an expert and could be mistaken.

[aloeliger]

@missirol I don't think we should need to change anything much else in the configurations? This just adds the ZDC packer to the GT packing step, so anywhere that is used should get this by default. Most of the configurations you linked are defining L1 emulator unpack steps that otherwise, except for L1's emulation of L1, go un-used, or at least that is my interpretation. In any case, I don't see a GT step in any of those that could be modified to account for ZDC I think.

[aloeliger]

@matt2275 Did you have any plots or outputs from the RAW->DIGI->RAW test you performed to test the packer?

[matt2275]

Here is the ZDC energy distribution unpacked ( first image with title including gtstage2digis) and then ZDC energy unpacked packed and unpacked again ( second image with title including unpackgtStage2). Both distributions look identical and have identical statistics

[aloeliger]

Here is the ZDC energy distribution unpacked ( first image with title including gtstage2digis) and then ZDC energy unpacked packed and unpacked again ( second image with title including unpackgtStage2). Both distributions look identical and have identical statistics

@eyigitba FYI

[aloeliger]

please test

[matt2275]

I think the pull request is ready for review. In addition to making sure the repacked zdc sums match the original zdc sums. I made sure the new zdc packer wouldn't cause a crash if the collection name were incorrect or unused by the cms job. In that case, it gives a warning that the collection could not be found but doesn't throw any fatal errors. Is there any other things I should check before marking the pull request ready for review?

[aloeliger]

@matt2275 I think that's good for now. Please mark this as good for review and maybe we can ping experts for any extra testing if needed.

[aloeliger]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-541f95/37742/summary.html
COMMIT: 2b0b53d
CMSSW: CMSSW_14_1_X_2024-02-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44019/37742/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 10 lines from the logs
• Reco comparison results: 53 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3011576
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3011548
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44019/39399

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File EventFilter/L1TRawToDigi/plugins/implementations_stage2/GTSetup.cc modified in PR(s): CICADA-uGT emulator additions #44222

[cmsbuild]

Pull request has been put on hold by @antoniovilela
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[cmsbuild]

Pull request #44019 was updated. @aloeliger, @epalencia, @cmsbuild can you please check and sign again.

[antoniovilela]

unhold

[antoniovilela]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-541f95/38050/summary.html
COMMIT: 8f4b222
CMSSW: CMSSW_14_1_X_2024-03-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44019/38050/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 49 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297383
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297357
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

re-sign

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1