Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Add customize to include Alpaka HCal PF Clustering at HLT #43979

Conversation

waredjeb
Copy link
Contributor

@waredjeb waredjeb commented Feb 15, 2024

This is a backport of #43971

This PR add customizeHLTforAlpakaParticleFlowClustering() to customizeHLTForAlpaka() to integrate the Alpaka HCAL PF Clustering at HLT.

The function defines all the needed modules and replace them in the necessary Sequences. Currently it also run the Alpaka CPU-serial version up to the PFClusterSoA collection, before the Legacy conversion.

To compare the GPU version against the CPU version a follow-up PR will be needed to perform the CPU legacy conversion and the comparison at DQM.
Validation

Validated running the following HLT configuration

hltGetConfiguration /dev/CMSSW_14_0_0/GRun --unprescale --output all --globaltag auto:phase1_2024_realistic --mc --max-events 10 --input /store/mc/Run3Winter24Digi/TT_TuneCP5_13p6TeV_powheg-pythia8/GEN-SIM-RAW/133X_mcRun3_2024_realistic_v8-v2/80000/dc984f7f-2e54-48c4-8950-5daa848b6db9.root --customise HLTrigger/Configuration/customizeHLTforAlpaka.customizeHLTforAlpaka

And also by merging #43958 and running workflow 12434.423

FYI @jsamudio @hatakeyamak

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 15, 2024

A new Pull Request was created by @waredjeb (Wahid Redjeb) for CMSSW_14_0_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @mmusich, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@silviodonato, @Martin-Grunewald, @missirol this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 15, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor

mmusich commented Feb 15, 2024

backport of #43971

@mmusich
Copy link
Contributor

mmusich commented Feb 15, 2024

type pf

@mmusich
Copy link
Contributor

mmusich commented Feb 15, 2024

And also by merging #43701 and running workflow 12434.423

is there a backport of this too?

@waredjeb
Copy link
Contributor Author

And also by merging #43701 and running workflow 12434.423

is there a backport of this too?

Yes: #43958

@mmusich
Copy link
Contributor

mmusich commented Feb 15, 2024

Yes: #43958

please amend the PR description then.

@mmusich
Copy link
Contributor

mmusich commented Feb 15, 2024

enable gpu

@mmusich
Copy link
Contributor

mmusich commented Feb 15, 2024

test parameters:

  • workflow_opts_gpu= -w upgrade
  • workflows_gpu= 12434.423

@mmusich
Copy link
Contributor

mmusich commented Feb 15, 2024

will trigger test here only once #43971 (comment) is clarified.

@waredjeb waredjeb force-pushed the integratePFAlpakaClusteringAtHLT_14_0_0_pre3 branch from 2b472df to 28e9220 Compare February 15, 2024 14:45
@cmsbuild
Copy link
Contributor

Pull request #43979 was updated. @mmusich, @Martin-Grunewald, @cmsbuild can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Feb 15, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Feb 15, 2024

@cmsbuild, please abort

@mmusich
Copy link
Contributor

mmusich commented Feb 16, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26f5d9/37514/summary.html
COMMIT: 28e9220
CMSSW: CMSSW_14_0_X_2024-02-15-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43979/37514/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 90 lines to the logs
  • Reco comparison results: 51 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248626
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248595
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 35 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 40949
  • DQMHistoTests: Total failures: 1151
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 39798
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 15 edm output root files, 4 DQM output files
  • TriggerResults: found differences in 1 / 3 workflows

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

  • Fast-track merging of backport for 14_0_0 build.

@cmsbuild cmsbuild merged commit 1816fe8 into cms-sw:CMSSW_14_0_X Feb 16, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants