Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Fix LHCInfoPer* PopCons to produce lumi-type IOVs when running in duringFill mode #43972

Conversation

francescobrivio
Copy link
Contributor

PR description:

Verbatim backport of #43837.

Update the LHCInfoPerLS and LHCInfoPeFill PopCons so that, when running in duringFill mode (used to populate the HLT GT), they produce lumiid-type IOVs.

PR validation:

See master PR.
Also, the LHCInfoPer* O2Os will be validated by the AlCa-DB group before deploying them in production.

Backport:

Backport of #43837

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 15, 2024

A new Pull Request was created by @francescobrivio for CMSSW_14_0_X.

It involves the following packages:

  • CondTools/RunInfo (db)

@perrotta, @saumyaphor4252, @francescobrivio, @cmsbuild, @consuegs can you please review it and eventually sign? Thanks.
@mmusich, @PonIlya, @yuanchao, @rsreds this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 15, 2024

cms-bot internal usage

@francescobrivio
Copy link
Contributor Author

backport of #43837

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df1a84/37477/summary.html
COMMIT: 3a0b16f
CMSSW: CMSSW_14_0_X_2024-02-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43972/37477/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 9 lines to the logs
  • Reco comparison results: 43 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248626
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248604
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

Pull request #43972 was updated. @cmsbuild, @francescobrivio, @consuegs, @saumyaphor4252, @perrotta can you please check and sign again.

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df1a84/37626/summary.html
COMMIT: e74ddb7
CMSSW: CMSSW_14_0_X_2024-02-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43972/37626/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df1a84/37643/summary.html
COMMIT: e74ddb7
CMSSW: CMSSW_14_0_X_2024-02-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43972/37643/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 27 lines to the logs
  • Reco comparison results: 35 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248461
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248439
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2024

Pull request #43972 was updated. @consuegs, @cmsbuild, @perrotta, @saumyaphor4252, @francescobrivio can you please check and sign again.

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df1a84/37858/summary.html
COMMIT: 7aa6331
CMSSW: CMSSW_14_0_X_2024-03-01-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43972/37858/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@francescobrivio
Copy link
Contributor Author

+db

  • since the master PR has been signed by the AlCaDB conveners and it has been (successfully) merged in master since yesterday (last night's IB shows no errors related to this PR), I take the liberty to self-sign this backport

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link
Contributor Author

urgent

  • following the new guidelines defined in Guidelines for PR integration #44283 I mark this urgent and tag @cms-sw/orp-l2
  • all details have been included in a mail forwarded to ORM and Release Managers

@cmsbuild cmsbuild added the urgent label Mar 5, 2024
@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a8742b5 into cms-sw:CMSSW_14_0_X Mar 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants