-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-gex175X Backport #43876 to CMSSW version 14_0_X the changes for te 2024 version of GE21 geometry #43970
Conversation
… version of GE21 geometry
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_14_0_X. It involves the following packages:
@civanch, @makortel, @mdhildreth, @cmsbuild, @Dr15Jones, @bsunanda can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-466846/37472/summary.html Comparison SummarySummary:
|
+geometry |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
hold
|
Pull request has been put on hold by @antoniovilela |
@antoniovilela , there is no sense to hold this PR, because it is done only in order of consistency between GT and XML detector description. In production GT is used but if at any moment in time a test GT/XML will be needed for any reason there will be a confusion. It is why we are trying to backport XML modifications like this. Here extra chambers installed during YETS are added to geometry, this chambers will not be used for analysis of data but only to control their performance. |
We have asked and are waiting for a green light from PPD, this is why it is on hold. |
unhold |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
We can discuss this PR in the ORP meeting. |
+1 |
@antoniovilela, @rappoccio Please merge this. I need to use the IB to backport the next version (scenario definition) |
+1 |
PR description:
Backport #43876 to CMSSW version 14_0_X the changes for te 2024 version of GE21 geometry
PR validation:
Use the runTheMatrix test workflows
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backporting #43876 from the master which is already integrated