Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex175X Backport #43876 to CMSSW version 14_0_X the changes for te 2024 version of GE21 geometry #43970

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

bsunanda
Copy link
Contributor

PR description:

Backport #43876 to CMSSW version 14_0_X the changes for te 2024 version of GE21 geometry

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backporting #43876 from the master which is already integrated

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_14_0_X.

It involves the following packages:

  • Geometry/MuonCommonData (geometry)

@civanch, @makortel, @mdhildreth, @cmsbuild, @Dr15Jones, @bsunanda can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo, @ptcox, @watson-ij this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 15, 2024

cms-bot internal usage

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-466846/37472/summary.html
COMMIT: b78411f
CMSSW: CMSSW_14_0_X_2024-02-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43970/37472/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@bsunanda
Copy link
Contributor Author

+geometry

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

hold

  • While this is further discussed.

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @antoniovilela
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@civanch
Copy link
Contributor

civanch commented Feb 16, 2024

@antoniovilela , there is no sense to hold this PR, because it is done only in order of consistency between GT and XML detector description. In production GT is used but if at any moment in time a test GT/XML will be needed for any reason there will be a confusion. It is why we are trying to backport XML modifications like this. Here extra chambers installed during YETS are added to geometry, this chambers will not be used for analysis of data but only to control their performance.

@antoniovilela
Copy link
Contributor

@antoniovilela , there is no sense to hold this PR, because it is done only in order of consistency between GT and XML detector description. In production GT is used but if at any moment in time a test GT/XML will be needed for any reason there will be a confusion. It is why we are trying to backport XML modifications like this. Here extra chambers installed during YETS are added to geometry, this chambers will not be used for analysis of data but only to control their performance.

We have asked and are waiting for a green light from PPD, this is why it is on hold.
Thanks.

@antoniovilela
Copy link
Contributor

unhold

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

We can discuss this PR in the ORP meeting.

@jordan-martins
Copy link
Contributor

+1

@bsunanda
Copy link
Contributor Author

@antoniovilela, @rappoccio Please merge this. I need to use the IB to backport the next version (scenario definition)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b74bd14 into cms-sw:CMSSW_14_0_X Feb 21, 2024
10 checks passed
@bsunanda bsunanda deleted the Run3-gex175X branch February 22, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants