-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix globToRegex and put it in anonymous namespace #43967
Conversation
please test |
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43967/38870
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
c35da38
to
3072d4e
Compare
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43967/38873
|
A new Pull Request was created by @iarspider for master. It involves the following packages:
@tjavaid, @antoniovagnerini, @nothingface0, @rvenditti, @syuvivida can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-418761/37469/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
please test |
@iarspider , please open a backport of this for 14.0.X |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-418761/37475/summary.html Comparison SummarySummary:
|
type bug-fix |
@cms-sw/dqm-l2 can you please review it. |
The original PR was not in 14_0_X, should I backport it as well? |
Alright, I'll be able to get a bit later today. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Follow-up on comments in #43334
PR validation:
Bot tests