HCAL proprietary RelVal machinery update #43953

abdoulline · 2024-02-13T16:40:14Z

PR description:

HCAL is using its own RelVal machinery (macros/scripts/html + histos plotting .json files) in Validation/CaloTowers/test/...
for publishing RelVal comparison plots produced in an optimized/adjusted way
https://cms-docs.web.cern.ch/hcal-sw-validation/?dir=14_0_X
And uses RelMon only occasionally for some minimal auxiliary checks, as described in slide#4:
https://indico.cern.ch/event/1242712/contributions/5222784/attachments/2578491/4447489/HCAL_Validation_Jan20_2023_S.A.pdf

This is the fist-pass update/cleaning, which comes after ~6 (!) years of using
various private modifications of the files from private branches/locations of several involved people...

PR validation:

NB: no any regular wfs is affected.

Private full-fledged test for 14_0_0_pre2 vs pre1 RelVals for both "2023" and Phase2 (aka "2026D98") TTbar

successful

cmsbuild · 2024-02-13T16:40:48Z

cms-bot internal usage

cmsbuild · 2024-02-13T16:49:27Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43953/38832

This PR adds an extra 60KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43953/38832/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43953/38832/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2024-02-13T17:15:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43953/38835

This PR adds an extra 64KB to repository

cmsbuild · 2024-02-13T17:15:45Z

A new Pull Request was created by @abdoulline (Salavat Abdullin) for master.

It involves the following packages:

Validation/CaloTowers (dqm)

@cmsbuild, @antoniovagnerini, @syuvivida, @tjavaid, @nothingface0, @rvenditti can you please review it and eventually sign? Thanks.
@missirol, @hatakeyamak this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

tjavaid · 2024-02-14T19:26:09Z

please test

cmsbuild · 2024-02-14T22:07:34Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-409ab5/37464/summary.html
COMMIT: 6657a20
CMSSW: CMSSW_14_1_X_2024-02-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43953/37464/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 7 lines to the logs
Reco comparison results: 42 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3248554
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3248529
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

tjavaid · 2024-03-20T07:52:27Z

Validation/CaloTowers/test/macros/RelValHarvest_2023.py

                    # create file name for use with hcal scripts
                    info = fname.split("__")[2].replace(label, "").strip("-")
-
+                    #print "smDebug3: ",info


Hi @abdoulline , Do you want to remove such lines? If to be retained may write in the proper format, please.

tjavaid · 2024-03-20T07:54:38Z

Validation/CaloTowers/test/macros/RelValHarvest_2023.py

+                    # if camType == "DATA":
+                    #     iparts = info.split("_")
+		    #     info = ""
+		    #     skip = False
+		    #     for fragment in iparts:
+                    #         if skip:
+                    #             info = info.strip("_")
+                    #             skip = False
+                    #             continue
+                    #         if fragment == "RelVal":
+                    #             skip = True
+                    #             continue
+                    #         info += fragment
+                    #         info += "_"
+                    #     info = info.strip("_")


May I ask why do you just comment out this part now?
I also see commented lines in a few other places. Could you please see if you can do a possible cleaning and leave some explanation for the part that is to be retained? Thanks!

@tjavaid
Actually it's not me who wrote (and commented these lines).
I've got it from private files of the colleague, who has left CMS and HEP for industry.
So, this part needs to be revised in the future by a dedicated person (developer/maintainer),
so I'd like to keep them (as a kind of "document") to possibly reconsider in the future.
Actual update is just 1st "approximation" to get something operational wrt completely obsolete stuff in CMSSW...
Right now it works as such for our actual purposes.

If you really insist on removing some commented fragments in this /test area, I can do it.

cmsbuild · 2024-03-20T08:30:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43953/39564

This PR adds an extra 64KB to repository

cmsbuild · 2024-03-20T08:31:07Z

Pull request #43953 was updated. @rvenditti, @nothingface0, @tjavaid, @antoniovagnerini, @cmsbuild, @syuvivida can you please check and sign again.

tjavaid · 2024-03-20T12:40:01Z

please test

cmsbuild · 2024-03-20T15:53:56Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-409ab5/38295/summary.html
COMMIT: fb1e348
CMSSW: CMSSW_14_1_X_2024-03-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43953/38295/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 3 lines to the logs
Reco comparison results: 46 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3297369
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3297346
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

tjavaid · 2024-03-20T16:30:58Z

+1

cmsbuild · 2024-03-20T16:31:26Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-03-20T18:31:45Z

+1

Salavat added 2 commits February 13, 2024 16:22

HCAL RelVal machinery update for 14X el9

a6e34a8

update gcc12

737a932

cmsbuild added this to the CMSSW_14_1_X milestone Feb 13, 2024

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending code-checks-pending labels Feb 13, 2024

cmsbuild added code-checks-rejected and removed code-checks-pending labels Feb 13, 2024

code format

6657a20

cmsbuild added code-checks-pending and removed code-checks-rejected labels Feb 13, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 13, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 14, 2024

cmsbuild added tests-approved and removed tests-started labels Feb 14, 2024

adding 2024 miscellania

61bd465

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Mar 1, 2024

tjavaid reviewed Mar 20, 2024

View reviewed changes

some cleaning

fb1e348

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Mar 20, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 20, 2024

cmsbuild added tests-started and removed tests-pending labels Mar 20, 2024

cmsbuild added tests-approved and removed tests-started labels Mar 20, 2024

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Mar 20, 2024

cmsbuild added orp-approved and removed orp-pending labels Mar 20, 2024

cmsbuild merged commit 5a810f4 into cms-sw:master Mar 20, 2024
11 checks passed

This was referenced Mar 22, 2024

[CPP20][ALCA] Replace some enums with constexpr ints #44509

Merged

[CPP20][GEOMETRY] Replace some enums with constexpr ints #44514

Merged

abdoulline deleted the HCAL_RelVal_update_el9 branch May 11, 2024 20:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HCAL proprietary RelVal machinery update #43953

HCAL proprietary RelVal machinery update #43953

abdoulline commented Feb 13, 2024 •

edited

Loading

cmsbuild commented Feb 13, 2024 •

edited

Loading

cmsbuild commented Feb 13, 2024

cmsbuild commented Feb 13, 2024

cmsbuild commented Feb 13, 2024

tjavaid commented Feb 14, 2024

cmsbuild commented Feb 14, 2024

tjavaid Mar 20, 2024

tjavaid Mar 20, 2024

abdoulline Mar 20, 2024 •

edited

Loading

cmsbuild commented Mar 20, 2024

cmsbuild commented Mar 20, 2024

tjavaid commented Mar 20, 2024

cmsbuild commented Mar 20, 2024

tjavaid commented Mar 20, 2024

cmsbuild commented Mar 20, 2024

antoniovilela commented Mar 20, 2024

HCAL proprietary RelVal machinery update #43953

HCAL proprietary RelVal machinery update #43953

Conversation

abdoulline commented Feb 13, 2024 • edited Loading

PR description:

PR validation:

cmsbuild commented Feb 13, 2024 • edited Loading

cmsbuild commented Feb 13, 2024

cmsbuild commented Feb 13, 2024

cmsbuild commented Feb 13, 2024

tjavaid commented Feb 14, 2024

cmsbuild commented Feb 14, 2024

Comparison Summary

tjavaid Mar 20, 2024

Choose a reason for hiding this comment

tjavaid Mar 20, 2024

Choose a reason for hiding this comment

abdoulline Mar 20, 2024 • edited Loading

Choose a reason for hiding this comment

cmsbuild commented Mar 20, 2024

cmsbuild commented Mar 20, 2024

tjavaid commented Mar 20, 2024

cmsbuild commented Mar 20, 2024

Comparison Summary

tjavaid commented Mar 20, 2024

cmsbuild commented Mar 20, 2024

antoniovilela commented Mar 20, 2024

abdoulline commented Feb 13, 2024 •

edited

Loading

cmsbuild commented Feb 13, 2024 •

edited

Loading

abdoulline Mar 20, 2024 •

edited

Loading