Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_x Backport] EXOSoftDisplacedVertices skim #43940

Merged

Conversation

LangFelix1
Copy link
Contributor

Backport of #43936

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 12, 2024

A new Pull Request was created by @LangFelix1 for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@miquork, @AdrianoDee, @cmsbuild, @sunilUIET can you please review it and eventually sign? Thanks.
@missirol, @youyingli, @Martin-Grunewald, @fabiocos this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 12, 2024

cms-bot internal usage

@AdrianoDee
Copy link
Contributor

test parameters:

  • workflows = 140.103, 141.103

@AdrianoDee
Copy link
Contributor

please test

@AdrianoDee
Copy link
Contributor

@LangFelix1 could you change the name of the PR to make it clear it's a 14_0_X back port? As is it looks like a duplicate when browsing the PR list.

@LangFelix1 LangFelix1 changed the title EXOSoftDisplacedVertices skim Backport: EXOSoftDisplacedVertices skim Feb 14, 2024
@LangFelix1 LangFelix1 changed the title Backport: EXOSoftDisplacedVertices skim [14_0_x Backport] EXOSoftDisplacedVertices skim Feb 14, 2024
@AdrianoDee
Copy link
Contributor

+pdmv

@AdrianoDee
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-acab3e/37807/summary.html
COMMIT: c2a70b1
CMSSW: CMSSW_14_0_X_2024-02-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43940/37807/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 138 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3378922
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3378897
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.036000000000000004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 140.103 ): 0.012 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 140.103,... ): 0.008 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 141.103 ): 0.008 KiB MessageLogger/Warnings
  • Checked 208 log files, 169 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 72712d1 into cms-sw:CMSSW_14_0_X Mar 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants