Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration arguments for version and packing schema of covariance in DeepJetTag producer [14_0_X] #43939

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Feb 12, 2024

PR description:

This PR adds configuration arguments for version and packing schema of covariance to DeepBoostedJetTagInfoProducer module.
Those are used by the module when construction of hlt_features is enabled and when the features are constructed from reco::PFCandidates, i.e. when the module is run at HLT. In the current code those are hard-coded which causes issues when the HLT RECO and miniAOD steps are run together in one workflow as discussed in #43861 issue.

The implementation is just a technical change and do not change behavior of the module as default values of newly added configuration arguments are equal to values which were hard-coded.

This is verbatim backport of #43917 (actually the same development branch is used for both PRs)

PR validation:

Verified that newly added parameters do not change previously used values.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #43917 to 14_0_X release series that will be used for 2024 operations.

…s for hlt_features constructed from reco::PFCandidates
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 12, 2024

A new Pull Request was created by @mbluj for CMSSW_14_0_X.

It involves the following packages:

  • RecoBTag/FeatureTools (reconstruction)

@mandrenguyen, @cmsbuild, @jfernan2 can you please review it and eventually sign? Thanks.
@demuller, @JyothsnaKomaragiri, @Ming-Yan, @hqucms, @Senphy, @AnnikaStein, @missirol, @AlexDeMoor, @emilbols, @andrzejnovak this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 12, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor

mmusich commented Feb 12, 2024

type btv

@mmusich
Copy link
Contributor

mmusich commented Feb 12, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Feb 12, 2024

backport of #43917

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-826227/37378/summary.html
COMMIT: 675fb27
CMSSW: CMSSW_14_0_X_2024-02-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43939/37378/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 111 lines to the logs
  • Reco comparison results: 41 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248626
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248604
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

Need to wait for the master PR.

@mmusich
Copy link
Contributor

mmusich commented Feb 13, 2024

urgent

  • for 14_0_0, in order to be parsed in confDB for TSG purposes.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e17a572 into cms-sw:CMSSW_14_0_X Feb 15, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants