-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration arguments for version and packing schema of covariance in DeepJetTag producer [14_0_X] #43939
Conversation
…s for hlt_features constructed from reco::PFCandidates
A new Pull Request was created by @mbluj for CMSSW_14_0_X. It involves the following packages:
@mandrenguyen, @cmsbuild, @jfernan2 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
type btv |
@cmsbuild, please test |
backport of #43917 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-826227/37378/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
Need to wait for the master PR. |
urgent
|
+1 |
PR description:
This PR adds configuration arguments for version and packing schema of covariance to
DeepBoostedJetTagInfoProducer
module.Those are used by the module when construction of
hlt_features
is enabled and when the features are constructed fromreco::PFCandidates
, i.e. when the module is run at HLT. In the current code those are hard-coded which causes issues when the HLT RECO and miniAOD steps are run together in one workflow as discussed in #43861 issue.The implementation is just a technical change and do not change behavior of the module as default values of newly added configuration arguments are equal to values which were hard-coded.
This is verbatim backport of #43917 (actually the same development branch is used for both PRs)
PR validation:
Verified that newly added parameters do not change previously used values.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #43917 to 14_0_X release series that will be used for 2024 operations.