Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx353D Modify some of the cfg's in Validation/HGCalValidation to work for V16, V17, V18 scenarios of HGCal Geometry #43934

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

bsunanda
Copy link
Contributor

PR description:

Modify some of the cfg's in Validation/HGCalValidation to work for V16, V17, V18 scenarios of HGCal Geometry

PR validation:

Tested with the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 11, 2024

cms-bot internal usage

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43934/38790

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Validation/HGCalValidation (dqm)

@syuvivida, @antoniovagnerini, @tjavaid, @rvenditti, @nothingface0 can you please review it and eventually sign? Thanks.
@vandreev11, @pfs, @lgray, @hatakeyamak, @cseez, @missirol, @rovere, @sethzenz, @youyingli, @lecriste, @apsallid this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-591631/37340/summary.html
COMMIT: 152f24a
CMSSW: CMSSW_14_1_X_2024-02-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43934/37340/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@tjavaid
Copy link

tjavaid commented Feb 12, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 33ad2e0 into cms-sw:master Feb 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants