-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed unused code related to OwnVector #43931
Removed unused code related to OwnVector #43931
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43931/38787
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages:
@jfernan2, @cmsbuild, @sbein, @ssekmen, @civanch, @mdhildreth, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test FYI @makortel |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15b99c/37334/summary.html Comparison SummarySummary:
|
+reconstruction |
+1 @sbein , it is technical code clean-up, I do think it affect any result |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Remove unused code related to OwnVector. This is in preparation for a possible move to RNTuple from TTree as a persistence mechanism. RNTuple does not support OwnVector because it allows polymorphism.
This PR is just dealing with some of the easiest cases. Code that isn't used anymore (some was maybe never used). Matti initially identified this list in Issue #42734 and this issue also contains more information related to this. These are the "Clearly unused" cases on Matti's list. I spent some time with grep and git grep and double checking that they were not used. I tried to delete anything directly related OwnVector or there only to support OwnVector. There probably is more cleanup that could be done in this part of the code. For example, the class FastTrackerCluster appears to be completely unused. I'll delete it also if anyone asks.
An example of a typical class in this set of changes,
edm::OwnVector<SiPixelRecHit>
was initially committed in 2006 and then replaced by edmNew::DetSetVector in 2007, except the dictionaries were left in the code (maybe for backward compatibility at that time, I don't know) and never cleaned up.PR validation:
As a temporary test I added the following to OwnVector.h, then ran checkdeps, and then ran "scram b". It succeeded. This shows nothing uses OwnVector for these types. I did this for CMSSW_14_1_X_2024-02-08-1100 and CMSSW_10_6_39. This should eliminate the possibility anything could produce objects of these types or use them in any way. I guess the only possible weakness of this test is something might read an old file using a View or the code might be different in other releases, but that does not seem likely.
I removed this after running the test. It is not in the PR.