Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport [14_0]: Add low pt muon fix objects into phase 2 L1 event content. #43926

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

aloeliger
Copy link
Contributor

PR description:

Taken from #43869

This PR adds the low pt muon fix objects that are temporarily an input into the phase 2 GT emulator into L1 FEVTDEBUG content to have all emulator objects available. This should be temporary until the full kBMTF/GMT muon objects are available with all fixes.

PR validation:

Taken from #43869

New FEVTDEBUG has the required objects.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport of #43869. It is being backported in the hopes that HLT can include these objects in their Phase 2 MC production cycle, to be performed on CMSSW_14_0

@artlbv @cbotta @epalencia FYI. Let me know if you would like me to tag Soham as well.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2024

A new Pull Request was created by @aloeliger (Andrew Loeliger) for CMSSW_14_0_X.

It involves the following packages:

  • L1Trigger/Configuration (l1)

@epalencia, @aloeliger, @cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2024

cms-bot internal usage

@epalencia
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7289a3/37331/summary.html
COMMIT: fae6c47
CMSSW: CMSSW_14_0_X_2024-02-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43926/37331/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 146 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 39 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248626
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248598
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@epalencia
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@aloeliger
Copy link
Contributor Author

backport of #43869

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b42767c into cms-sw:CMSSW_14_0_X Feb 12, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants