Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport track jet eta quick fix #43922

Merged

Conversation

ccahoughton
Copy link
Contributor

PR description:

Backport of
#43852 (comment)

Bug fix needed for production of simulation samples. Error was in track jet emulator - tracks outside of the acceptable geometry were causing bin indexing to go out of scope. This resulted in a segmentation fault.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Original PR:
#43852 (comment)

Release cycle:
CMSSW_14_0_X

Need:
Requested by @srimanob

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

A new Pull Request was created by @ccahoughton for CMSSW_14_0_X.

It involves the following packages:

  • L1Trigger/L1TTrackMatch (l1, upgrade)

@aloeliger, @cmsbuild, @subirsarkar, @srimanob, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

cms-bot internal usage

@epalencia
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12957e/37316/summary.html
COMMIT: 732215c
CMSSW: CMSSW_14_0_X_2024-02-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43922/37316/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 100 lines to the logs
  • Reco comparison results: 56 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248626
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248595
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@epalencia
Copy link
Contributor

+l1

@subirsarkar
Copy link

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

backport of #43852

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2e79e50 into cms-sw:CMSSW_14_0_X Feb 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants