Implements HMT triggers in test vector code for uGT emulator in master #43921
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43921/38773
|
|
A new Pull Request was created by @nabrandman (Nathan) for master. It involves the following packages:
@cmsbuild, @aloeliger, @epalencia can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b4b35/37313/summary.html Comparison SummarySummary:
|
| @@ -224,6 +234,7 @@ namespace l1t { | |||
| //outputs | |||
| std::unique_ptr<l1t::EGammaBxCollection> egammas(new l1t::EGammaBxCollection(0, bxFirst, bxLast)); | |||
| std::unique_ptr<l1t::MuonBxCollection> muons(new l1t::MuonBxCollection(0, bxFirst, bxLast)); | |||
| std::unique_ptr<l1t::MuonShowerBxCollection> muonShowers(new l1t::MuonShowerBxCollection(0, bxFirst, bxLast)); | |||
There was a problem hiding this comment.
In the future, I think std::make_unique<l1t::MuonShowerBxCollection>(...args...) is preferred over new, but this is not the first/only example of that in this file.
| if (false) { // for debugging purposes | ||
| std::cout << "---- Non-existant Muon ------------------" << std::endl; | ||
| std::cout << "<< 0; mu->hwPhiAtVtx() = " << std::hex << std::setw(16) << std::setfill('0') | ||
| << ((cms_uint64_t)(0 & 0x3ff) << 0) << std::endl; | ||
| std::cout << "<< 10; mu->hwPt() = " << std::hex << std::setw(16) << std::setfill('0') | ||
| << ((cms_uint64_t)(0 & 0x1ff) << 10) << std::endl; | ||
| std::cout << "<< 19; mu->hwQual() = " << std::hex << std::setw(16) << std::setfill('0') | ||
| << ((cms_uint64_t)(0 & 0xf) << 19) << std::endl; | ||
| std::cout << "<< 23; mu->hwEtaAtVtx() = " << std::hex << std::setw(16) << std::setfill('0') | ||
| << ((cms_uint64_t)(0 & 0x1ff) << 23) << std::endl; | ||
| std::cout << "<< 32; mu->hwIso() = " << std::hex << std::setw(16) << std::setfill('0') | ||
| << ((cms_uint64_t)(0 & 0x3) << 32) << std::endl; | ||
| std::cout << "<< 34; mu->hwCharge() = " << std::hex << std::setw(16) << std::setfill('0') | ||
| << ((cms_uint64_t)(0 & 0x1) << 34) << std::endl; | ||
| std::cout << "<< 35; mu->hwChargeValid() = " << std::hex << std::setw(16) << std::setfill('0') | ||
| << ((cms_uint64_t)(0 & 0x1) << 35) << std::endl; | ||
| std::cout << "<< 43; mu->hwPhi() = " << std::hex << std::setw(16) << std::setfill('0') | ||
| << ((cms_uint64_t)(0 & 0x3ff) << 43) << std::endl; | ||
| std::cout << "<< 53; mu->hwPtUnconstrained() = " << std::hex << std::setw(16) << std::setfill('0') | ||
| << ((cms_uint64_t)(0 & 0xff) << 53) << std::endl; | ||
| std::cout << "<< 61: muShowerBit = " << std::hex << std::setw(16) << std::setfill('0') | ||
| << ((cms_uint64_t)(muShowerBit & 0x1) << 61) << std::endl; | ||
| std::cout << "<< 62; mu->hwDXY() = " << std::hex << std::setw(16) << std::setfill('0') | ||
| << ((cms_uint64_t)(0 & 0x3) << 62) << std::endl; | ||
| std::cout << "packedWord = " << std::hex << std::setw(16) << std::setfill('0') << packedVal | ||
| << std::endl; | ||
| std::cout << "----------------------" << std::endl; | ||
| } |
There was a problem hiding this comment.
Is this intended for general CMSSW use in L1 emulation? If it is, using logDebug instead of this always false block which is never used would be preferred.
|
hold
|
|
Pull request has been put on hold by @aloeliger |
|
@elfontan @nabrandman What is the status of validation of these changes? Are we okay to merge this? |
@elfontan @nabrandman Just a ping on whether this PRs changes have been validated firmware side. |
…ng unnecessary print statements from GtRecordDump based on feedback, updating test vector preparing scripts to use more recent menu and rootfiles.
cmsbuild
added
tests-pending
code-checks-pending
and removed
tests-approved
code-checks-approved
labels
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43921/39825
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43921/40083
|
|
Pull request #43921 was updated. @epalencia, @cmsbuild, @aloeliger can you please check and sign again. |
|
@aloeliger Sorry, yes, this should now include all expected changes |
|
unhold |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b4b35/39069/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
|
+l1 |
cmsbuild
added
l1-approved
fully-signed
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Implements HMT triggers in test vector code for uGT emulator in master.
No changes are expected to the output.
This PR does not depend on any other PRs or externals.
PR validation:
Performed runTheMatrix with -l 11634.0, passed 5 out of 5 tests. Test vector code was also validated with firmware and was shown to be equivalent.
Changes were checked against "scram build code-format" to ensure they followed CMS Naming, Coding and Style Rules.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is not a backport.