Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] add phase2 customizations to TkAlMuonSelectors to increase selection efficiency #43892

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 7, 2024

backport of #43859

PR description:

See description at #43859

PR validation:

See description at #43859

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #43859 (same branch is used).

@mmusich
Copy link
Contributor Author

mmusich commented Feb 7, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2024

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_14_0_X.

It involves the following packages:

  • Alignment/CommonAlignmentProducer (alca)

@cmsbuild, @consuegs, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@yuanchao, @mmusich, @adewit, @pakhotin, @tlampen, @tocheng, @rsreds this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Feb 7, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-45a1cf/37276/summary.html
COMMIT: 175abba
CMSSW: CMSSW_14_0_X_2024-02-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43892/37276/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

perrotta commented Feb 8, 2024

+1

  • Master version successfully merged and passing the IB tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 15570d7 into cms-sw:CMSSW_14_0_X Feb 9, 2024
21 checks passed
@mmusich mmusich deleted the mm_dev_fix_phase2_alcareco_muon_selection branch February 9, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants