Produce sMajor, sMinor in EgammaHLTClusterShapeProducer #43885

swagata87 · 2024-02-07T07:59:12Z

PR description:

Produce sMajor, sMinor via EgammaHLTClusterShapeProducer in ECAL. These variables are useful for displaced e/gamma HLT path. In phase2, we would like to add some displaced e/gamma paths where we would like to cut on these variables. This PR is to enable such studies easily for Phase2 HLT.

PR validation:

runTheMatrix.py -l 24834.0 worked fine.

Additionally, checked that we are getting reasonable values for sMajor, sMinor. This check was done from Phase2 EGamma HLT setup, using this root file:

/store/mc/Phase2Spring23DIGIRECOMiniAOD/DYToLL_M-10To50_TuneCP5_14TeV-pythia8/GEN-SIM-DIGI-RAW-MINIAOD/noPU_131X_mcRun4_realistic_v5-v1/30000/66eea162-e0cd-4752-a295-5bbca4bd8363.root (1000 events)

These are the histograms for sMajor and sMinor, for barrel, at HLT

PS: Took this opportunity to do some cleanup. Removed sigmaEtaEta type variables as they are obsolete.

cmsbuild · 2024-02-07T07:59:37Z

cms-bot internal usage

cmsbuild · 2024-02-07T08:07:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43885/38741

This PR adds an extra 12KB to repository

cmsbuild · 2024-02-07T08:07:42Z

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master.

It involves the following packages:

RecoEgamma/EgammaHLTProducers (hlt)

@cmsbuild, @mmusich, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@ram1123, @varuns23, @HuguesBrun, @afiqaize, @sobhatta, @jainshilpi, @silviodonato, @cericeci, @Fedespring, @sameasy, @Prasant1993, @valsdav, @Sam-Harper, @missirol, @a-kapoor, @lgray this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

swagata87 · 2024-02-07T08:08:22Z

type egamma

Martin-Grunewald · 2024-02-07T08:23:53Z

RecoEgamma/EgammaHLTProducers/plugins/EgammaHLTClusterShapeProducer.cc

+
+    reco::CaloClusterPtr SCseed = recoecalcandref->superCluster()->seed();
+    const EcalRecHitCollection* rechits =
+        (std::abs(recoecalcandref->eta()) < 1.479) ? rechitsEB_.product() : rechitsEE_.product();


Further up in this file there is a line:

if (EtaSC > 1.479)

should that be std::abs(EtaSC) as this variable is also a recoecalcandref->eta()?
Ie double EtaSC = std::abs(recoecalcandref->eta());

this could be a bug;
but the else { loop where this potential bug lives, is not used anywhere in egamma HLT.
So even if it is a bug it can be ignored.
I can't confirm if it's a bug as I don't know what this is actually doing:

if (EtaSC > 1.479) sigmaee = sigmaee - 0.02 * (EtaSC - 2.3); }

Would it be OK to remove the else branch and put the then branch to be executed always?

yes I think it's better to remove it as a cleanup.
I'm talking to EGM POG just to make sure they agree.
I will get back to this.

(After a chat with Riccardo S.) removed the else loop, as sigmaEtaEta etc is obsolete and not used anymore in favor of the better variable like sigmaIEtaIEta etc.

@cms-sw/egamma-pog-l2
@DebabrataBhowmik
@ravindkv

Could you please backport to 14_0?

Do we need a backport? The main aim of this PR is to be able to perform phase2 HLT studies easily, using the 2 variables sMajor and sMinor. It's not that much needed for Run3 actually.

According to the PPD schedule, 14_0 is to be used for the Phase-2 MC campaign:
https://docs.google.com/spreadsheets/d/1XqkT_HYs04ZbLKs7k4SyPZ9DcNfN7ZmHQxv2I_iI-Hw/edit#gid=402259138

ah okay, thanks Martin. I will make a backport to 14_0

Backport PR is made here: #43908

cmsbuild · 2024-02-07T14:31:15Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43885/38744

This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43885/38744/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43885/38744/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2024-02-07T14:41:19Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43885/38746

This PR adds an extra 24KB to repository

cmsbuild · 2024-02-07T14:41:44Z

Pull request #43885 was updated. @Martin-Grunewald, @mmusich, @cmsbuild can you please check and sign again.

Martin-Grunewald · 2024-02-07T16:00:11Z

please test

cmsbuild · 2024-02-07T19:48:19Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8f3bfa/37274/summary.html
COMMIT: 59bcf97
CMSSW: CMSSW_14_1_X_2024-02-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43885/37274/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 39 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3248626
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3248604
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

cmsbuild · 2024-02-11T08:28:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43885/38792

This PR adds an extra 20KB to repository

cmsbuild · 2024-02-11T08:28:53Z

Pull request #43885 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

swagata87 · 2024-02-11T08:36:15Z

@cmsbuild please test

cmsbuild · 2024-02-11T08:36:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43885/38793

This PR adds an extra 40KB to repository

cmsbuild · 2024-02-11T08:36:41Z

Pull request #43885 was updated. @Martin-Grunewald, @mmusich can you please check and sign again.

cmsbuild · 2024-02-11T12:21:29Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8f3bfa/37342/summary.html
COMMIT: bf13d2f
CMSSW: CMSSW_14_1_X_2024-02-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43885/37342/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 70 lines to the logs
Reco comparison results: 40 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3248626
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3248604
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

Martin-Grunewald · 2024-02-12T09:38:20Z

+1

cmsbuild · 2024-02-12T09:38:47Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-02-12T17:43:18Z

+1

cmsbuild added this to the CMSSW_14_1_X milestone Feb 7, 2024

cmsbuild added hlt-pending pending-signatures tests-pending orp-pending code-checks-pending labels Feb 7, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 7, 2024

cmsbuild added the egamma label Feb 7, 2024

Martin-Grunewald reviewed Feb 7, 2024

View reviewed changes

cmsbuild added code-checks-pending and removed code-checks-approved labels Feb 7, 2024

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Feb 7, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 7, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 7, 2024

cmsbuild removed the tests-started label Feb 7, 2024

cmsbuild added the code-checks-pending label Feb 11, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 11, 2024

adapt phase2 cfgs

bf13d2f

cmsbuild added code-checks-pending and removed code-checks-approved labels Feb 11, 2024

cmsbuild added tests-started code-checks-approved and removed tests-pending code-checks-pending labels Feb 11, 2024

cmsbuild added tests-approved and removed tests-started labels Feb 11, 2024

cmsbuild added hlt-approved fully-signed and removed hlt-pending pending-signatures labels Feb 12, 2024

cmsbuild added orp-approved and removed orp-pending labels Feb 12, 2024

cmsbuild merged commit 6b1b191 into cms-sw:master Feb 12, 2024
11 checks passed

This was referenced Feb 13, 2024

Update Alpaka to version 1.1.0 #43772

Merged

Added test for PSet description wildcard with plugin #43944

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Produce sMajor, sMinor in EgammaHLTClusterShapeProducer #43885

Produce sMajor, sMinor in EgammaHLTClusterShapeProducer #43885

swagata87 commented Feb 7, 2024 •

edited

Loading

cmsbuild commented Feb 7, 2024 •

edited

Loading

cmsbuild commented Feb 7, 2024

cmsbuild commented Feb 7, 2024

swagata87 commented Feb 7, 2024

Martin-Grunewald Feb 7, 2024 •

edited

Loading

swagata87 Feb 7, 2024

Martin-Grunewald Feb 7, 2024

swagata87 Feb 7, 2024

swagata87 Feb 7, 2024

Martin-Grunewald Feb 7, 2024

swagata87 Feb 7, 2024

Martin-Grunewald Feb 7, 2024

swagata87 Feb 7, 2024

swagata87 Feb 8, 2024

cmsbuild commented Feb 7, 2024

cmsbuild commented Feb 7, 2024

cmsbuild commented Feb 7, 2024

Martin-Grunewald commented Feb 7, 2024

cmsbuild commented Feb 7, 2024

cmsbuild commented Feb 11, 2024

cmsbuild commented Feb 11, 2024

swagata87 commented Feb 11, 2024

cmsbuild commented Feb 11, 2024

cmsbuild commented Feb 11, 2024

cmsbuild commented Feb 11, 2024

Martin-Grunewald commented Feb 12, 2024

cmsbuild commented Feb 12, 2024

antoniovilela commented Feb 12, 2024

Produce sMajor, sMinor in EgammaHLTClusterShapeProducer #43885

Produce sMajor, sMinor in EgammaHLTClusterShapeProducer #43885

Conversation

swagata87 commented Feb 7, 2024 • edited Loading

PR description:

PR validation:

cmsbuild commented Feb 7, 2024 • edited Loading

cmsbuild commented Feb 7, 2024

cmsbuild commented Feb 7, 2024

swagata87 commented Feb 7, 2024

Martin-Grunewald Feb 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Feb 7, 2024

cmsbuild commented Feb 7, 2024

cmsbuild commented Feb 7, 2024

Martin-Grunewald commented Feb 7, 2024

cmsbuild commented Feb 7, 2024

Comparison Summary

cmsbuild commented Feb 11, 2024

cmsbuild commented Feb 11, 2024

swagata87 commented Feb 11, 2024

cmsbuild commented Feb 11, 2024

cmsbuild commented Feb 11, 2024

cmsbuild commented Feb 11, 2024

Comparison Summary

Martin-Grunewald commented Feb 12, 2024

cmsbuild commented Feb 12, 2024

antoniovilela commented Feb 12, 2024

swagata87 commented Feb 7, 2024 •

edited

Loading

cmsbuild commented Feb 7, 2024 •

edited

Loading

Martin-Grunewald Feb 7, 2024 •

edited

Loading