Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT development: add unit test for online vs dev tables consistency [14.0.X] #43884

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 7, 2024

backport of #43865

PR description:

Title says it all, add a script to test the consistency of the paths added in the online_<...>.txt sub-tables w.r.t to the development subtables <...>.txt (excluding the elements known to differ ("HLTAnalyzerEndpath" "RatesMonitoring" "DQMHistograms").
A corresponding unit test run on all the sub-tables supported by TSG / STORM is added
Additionally a mistake in the integration of CMSHLT-3019, introduced in PR #43842 is corrected (the path HLT_IsoMu27_MediumDeepTauPFTauHPS20_eta2p1_SingleL1_v removed from the GRun table should be removed also from online_grun one.

PR validation:

scram b runtests_test_OnlineVsDevTablesConsistency

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #43865

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2024

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_14_0_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @mmusich, @cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Feb 7, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-398bce/37259/summary.html
COMMIT: 5a55dd7
CMSSW: CMSSW_14_0_X_2024-02-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43884/37259/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Feb 7, 2024

+hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 285c78c into cms-sw:CMSSW_14_0_X Feb 8, 2024
21 checks passed
@mmusich mmusich deleted the mm_dev_add_test_OnlineVsDevTablesConsistency branch February 9, 2024 06:31
@mmusich mmusich restored the mm_dev_add_test_OnlineVsDevTablesConsistency branch February 9, 2024 06:31
@mmusich mmusich deleted the mm_dev_add_test_OnlineVsDevTablesConsistency branch February 9, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants