SoA range checking: adds inter operability between range checked and non range checked [14.0.x] #43881
Conversation
This change allows providing a range checked to the code, presumably to debug without changing the PortableCollections (which always provide non-range checking views). Range and non-range checking variants can be contructed from one another.
Positivty tests were missing as the indices are of a signed type (for ROOT compatibility).
Explain that using a typedef as a template parameter causes the ROOT dicionary generation to fail.
|
backport #41928 |
|
please test |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_14_0_X. It involves the following packages:
can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
cms-bot internal usage |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d367b0/37255/summary.html Comparison SummarySummary:
|
|
+1 |
PR description:
This PR adds copy and construction compatibility between
Views andConstViews (respectively, no const evasion was created) with different template parameters. This allows compile time switching to the range checking variant for debugging. TheViews are usually used from thePortableCollections(and are non range checking). Changing the signature or a function or kernel to use the range checking variant simply requires a type definition change and the creation of a translating variable at the kernel call. The program will then half immediately on range violation.PR validation:
The copy and construction are now validated in a test, as part of this PR. I addition this feature was used and validated to debug an actual out of range error during module debugging.
Backport status:
Backport of #41928 to CMSSW_14_0_X for data taking.