Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 13_3_X (3/N) [14_0_X] #43875

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 6, 2024

backport of #43867

PR description:

Development of HLT menus for CMSSW_13_3_X (branch 14_0_X):

  • this is an intermediate update towards the 2024 proton-proton run data-taking (and the final one foreseen to happen in the CMSSW_13_3_X cycle before moving to a new template in CMSSW_14_0_X).

This is the PR for the master branch, which will then be backported down to 13_3_X (the latter is the release cycle currently used for Run-3 HLT-menu development).

This update includes the integration of the following JIRA tickets:

  • CMSHLT-2993 [MUO]: HLT path for High-pT muons seeded by the L1 Muon Shower Trigger

PR validation:

TSG integration tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #43867 to CMSSW_14_0_X.

This is an intermediate update towards the 2024 proton-proton run data-taking.
This update includes the integration of the following JIRA tickets:
- [CMSHLT-2993](https://its.cern.ch/jira/browse/CMSHLT-2993) [MUO]: HLT path for High-pT muons seeded by the L1 Muon Shower Trigger
@mmusich mmusich changed the title HLT menu development for 13_3_X (branch: 14_0_X) HLT menu development for 13_3_X (3/N) [14_0_X] Feb 6, 2024
@mmusich
Copy link
Contributor Author

mmusich commented Feb 6, 2024

@cmsbuild ping?

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2024

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_14_0_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @mmusich, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@missirol, @silviodonato, @Martin-Grunewald this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Feb 6, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5ab94/37240/summary.html
COMMIT: 016eb7d
CMSSW: CMSSW_14_0_X_2024-02-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43875/37240/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 90 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 59 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248611
  • DQMHistoTests: Total failures: 1195
  • DQMHistoTests: Total nulls: 4
  • DQMHistoTests: Total successes: 3247390
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.44 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 141.042,... ): 0.480 KiB HLT/Filters
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Feb 6, 2024

+hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Feb 7, 2024

urgent

  • @cms-sw/orp-l2 please integrate this last PR with HLT template from 13.3.X, so that we can start development in the new production cycle. Thank you!

@cmsbuild cmsbuild added the urgent label Feb 7, 2024
@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ef581d2 into cms-sw:CMSSW_14_0_X Feb 7, 2024
20 of 21 checks passed
@mmusich mmusich deleted the HLTdevelopment133X_for140X branch February 7, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants