Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-organize workflows exercising the SiPixelAliHGCombined PCL workflow #43810

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jan 30, 2024

PR description:

Better usage of relval resources: exercise the new PromptCalibProdSiPixelAliHGComb workflow introduced at #43721 only on di-muon resonant data in the newly added workflow 1001.4 , while it is removed on the existing ones 1001.2 and 1001.3 which run over ZeroBias and SingleMuon data.

PR validation:

runTheMatrix.py -l 1001.2,1001.3,1001.4 -t 4 -j 8 --ibeos runs

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will be backported to CMSSW_14_0_X.

@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Jan 30, 2024
@mmusich
Copy link
Contributor Author

mmusich commented Jan 30, 2024

test parameters:

  • workflows = 1001.2, 1001.3, 1001.4

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 30, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Jan 30, 2024

please test for CMSSW_14_0_ASAN_X

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43810/38611

  • This PR adds an extra 56KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@subirsarkar, @sunilUIET, @srimanob, @miquork, @AdrianoDee can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @makortel, @fabiocos, @slomeo this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abfa5c/37105/summary.html
COMMIT: 6fd6f58
CMSSW: CMSSW_14_0_ASAN_X_2024-01-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43810/37105/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

The relvals timed out after 4 hours.

  • 24900.024900.0_CloseByPGun_CE_H_Coarse_Scint+2026D98/step2_CloseByPGun_CE_H_Coarse_Scint+2026D98.log
  • 24896.024896.0_CloseByPGun_CE_E_Front_120um+2026D98/step2_CloseByPGun_CE_E_Front_120um+2026D98.log
  • 24834.024834.0_TTbar_14TeV+2026D98/step2_TTbar_14TeV+2026D98.log
Expand to see more relval errors ...

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2024

Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_14_0_X, CMSSW_14_1_X Feb 6, 2024
@mmusich mmusich changed the title re-organize workflows exercising the SiPixel HGCombined workflow re-organize workflows exercising the SiPixelAliHGCombined PCL workflow Feb 11, 2024
@cmsbuild cmsbuild modified the milestones: CMSSW_14_0_X, CMSSW_14_1_X Feb 11, 2024
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43810/38796

@cmsbuild
Copy link
Contributor

Pull request #43810 was updated. @miquork, @sunilUIET, @AdrianoDee, @srimanob, @subirsarkar can you please check and sign again.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abfa5c/37346/summary.html
COMMIT: 1ae0076
CMSSW: CMSSW_14_1_ASAN_X_2024-02-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43810/37346/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

The relvals timed out after 4 hours.

@mmusich
Copy link
Contributor Author

mmusich commented Feb 11, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abfa5c/37352/summary.html
COMMIT: 1ae0076
CMSSW: CMSSW_14_1_X_2024-02-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43810/37352/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 66 lines to the logs
  • Reco comparison results: 37 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248626
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248604
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Feb 14, 2024

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 any comment about this?

@AdrianoDee
Copy link
Contributor

+pdmv

@subirsarkar
Copy link

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b43bd96 into cms-sw:master Feb 18, 2024
17 of 18 checks passed
@mmusich mmusich deleted the mm_dev_reorganize_HGCombinedWorkflows branch February 18, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants