[14_1_X] [Phase-2] Change Phase-2 HLT Egamma paths to use the GT emulator #43809

SohamBhattacharya · 2024-01-30T06:35:28Z

This PR changes Phase-2 HLT Egamma paths to use the GT emulator.
Tests:

Testing on 200 events (PU 0) of [1] shows minor differences before [1a] and after [1b]
Testing on 200 events (PU 0) of [2] shows minor differences before [2a] and after [2b]

Tagging @cms-sw/l1-l2
@rovere fyi

Request for egamma @ravindkv @DebabrataBhowmik @skeshri : please test the egamma path efficiencies in a PU200 sample.

[1]
/store/relval/CMSSW_14_0_0_pre2/RelValZEE_14/GEN-SIM-DIGI-RAW/133X_mcRun4_realistic_v1_STD_2026D98_noPU-v2/2590000/0cfd31b7-99fd-4dcf-9da3-80aaea95597c.root

[1a]

HLT-Report      48     200     200     200      89  44.50000     0.0     0.0       0 HLT_Ele32_WPTight_Unseeded
HLT-Report      49     200     200     200     102  51.00000     0.0     0.0       0 HLT_Ele26_WP70_Unseeded
HLT-Report      50     200     200     200       0   0.00000     0.0     0.0       0 HLT_Photon108EB_TightID_TightIso_Unseeded
HLT-Report      51     200     200     200       0   0.00000     0.0     0.0       0 HLT_Photon187_Unseeded
HLT-Report      52     200     200     200      63  31.50000     0.0     0.0       0 HLT_DoubleEle25_CaloIdL_PMS2_Unseeded
HLT-Report      53     200     200     200      74  37.00000     0.0     0.0       0 HLT_Diphoton30_23_IsoCaloId_Unseeded
HLT-Report      54     200     200     200      89  44.50000     0.0     0.0       0 HLT_Ele32_WPTight_L1Seeded
HLT-Report      55     200     200     200       1   0.50000     0.0     0.0       0 HLT_Ele115_NonIso_L1Seeded
HLT-Report      56     200     200     200     103  51.50000     0.0     0.0       0 HLT_Ele26_WP70_L1Seeded
HLT-Report      57     200     200     200       0   0.00000     0.0     0.0       0 HLT_Photon108EB_TightID_TightIso_L1Seeded
HLT-Report      58     200     200     200       0   0.00000     0.0     0.0       0 HLT_Photon187_L1Seeded
HLT-Report      59     200     200     200      64  32.00000     0.0     0.0       0 HLT_DoubleEle25_CaloIdL_PMS2_L1Seeded
HLT-Report      60     200     200     200      59  29.50000     0.0     0.0       0 HLT_DoubleEle23_12_Iso_L1Seeded
HLT-Report      61     200     200     200      73  36.50000     0.0     0.0       0 HLT_Diphoton30_23_IsoCaloId_L1Seeded
HLT-Report      65     200     200     200     168  84.00000     0.0     0.0       0 MC_Ele5_Open_Unseeded
HLT-Report      66     200     200     200     166  83.00000     0.0     0.0       0 MC_Ele5_Open_L1Seeded

[1b]

HLT-Report      48     200     200     200      90  45.00000     0.0     0.0       0 HLT_Ele32_WPTight_Unseeded
HLT-Report      49     200     200     200     103  51.50000     0.0     0.0       0 HLT_Ele26_WP70_Unseeded
HLT-Report      50     200     200     200       0   0.00000     0.0     0.0       0 HLT_Photon108EB_TightID_TightIso_Unseeded
HLT-Report      51     200     200     200       0   0.00000     0.0     0.0       0 HLT_Photon187_Unseeded
HLT-Report      52     200     200     200      63  31.50000     0.0     0.0       0 HLT_DoubleEle25_CaloIdL_PMS2_Unseeded
HLT-Report      53     200     200     200      74  37.00000     0.0     0.0       0 HLT_Diphoton30_23_IsoCaloId_Unseeded
HLT-Report      54     200     200     200      87  43.50000     0.0     0.0       0 HLT_Ele32_WPTight_L1Seeded
HLT-Report      55     200     200     200       1   0.50000     0.0     0.0       0 HLT_Ele115_NonIso_L1Seeded
HLT-Report      56     200     200     200     101  50.50000     0.0     0.0       0 HLT_Ele26_WP70_L1Seeded
HLT-Report      57     200     200     200       0   0.00000     0.0     0.0       0 HLT_Photon108EB_TightID_TightIso_L1Seeded
HLT-Report      58     200     200     200       0   0.00000     0.0     0.0       0 HLT_Photon187_L1Seeded
HLT-Report      59     200     200     200      64  32.00000     0.0     0.0       0 HLT_DoubleEle25_CaloIdL_PMS2_L1Seeded
HLT-Report      60     200     200     200      59  29.50000     0.0     0.0       0 HLT_DoubleEle23_12_Iso_L1Seeded
HLT-Report      61     200     200     200      73  36.50000     0.0     0.0       0 HLT_Diphoton30_23_IsoCaloId_L1Seeded
HLT-Report      65     200     200     200     168  84.00000     0.0     0.0       0 MC_Ele5_Open_Unseeded
HLT-Report      66     200     200     200     155  77.50000     0.0     0.0       0 MC_Ele5_Open_L1Seeded

[2] /store/relval/CMSSW_14_0_0_pre2/RelValZpToEE_m6000_14TeV/GEN-SIM-DIGI-RAW/133X_mcRun4_realistic_v1_STD_2026D98_noPU-v2/2590000/01cd42e0-de56-4d6e-b71c-08ef9700b911.root

[2a]

HLT-Report      48     200     200     200     172  86.00000     0.0     0.0       0 HLT_Ele32_WPTight_Unseeded
HLT-Report      49     200     200     200     171  85.50000     0.0     0.0       0 HLT_Ele26_WP70_Unseeded
HLT-Report      50     200     200     200     152  76.00000     0.0     0.0       0 HLT_Photon108EB_TightID_TightIso_Unseeded
HLT-Report      51     200     200     200     156  78.00000     0.0     0.0       0 HLT_Photon187_Unseeded
HLT-Report      52     200     200     200     140  70.00000     0.0     0.0       0 HLT_DoubleEle25_CaloIdL_PMS2_Unseeded
HLT-Report      53     200     200     200     137  68.50000     0.0     0.0       0 HLT_Diphoton30_23_IsoCaloId_Unseeded
HLT-Report      54     200     200     200     172  86.00000     0.0     0.0       0 HLT_Ele32_WPTight_L1Seeded
HLT-Report      55     200     200     200     164  82.00000     0.0     0.0       0 HLT_Ele115_NonIso_L1Seeded
HLT-Report      56     200     200     200     171  85.50000     0.0     0.0       0 HLT_Ele26_WP70_L1Seeded
HLT-Report      57     200     200     200     152  76.00000     0.0     0.0       0 HLT_Photon108EB_TightID_TightIso_L1Seeded
HLT-Report      58     200     200     200     157  78.50000     0.0     0.0       0 HLT_Photon187_L1Seeded
HLT-Report      59     200     200     200     141  70.50000     0.0     0.0       0 HLT_DoubleEle25_CaloIdL_PMS2_L1Seeded
HLT-Report      60     200     200     200     114  57.00000     0.0     0.0       0 HLT_DoubleEle23_12_Iso_L1Seeded
HLT-Report      61     200     200     200     138  69.00000     0.0     0.0       0 HLT_Diphoton30_23_IsoCaloId_L1Seeded
HLT-Report      65     200     200     200     192  96.00000     0.0     0.0       0 MC_Ele5_Open_Unseeded
HLT-Report      66     200     200     200     192  96.00000     0.0     0.0       0 MC_Ele5_Open_L1Seeded

[2b]

HLT-Report      48     200     200     200     172  86.00000     0.0     0.0       0 HLT_Ele32_WPTight_Unseeded
HLT-Report      49     200     200     200     171  85.50000     0.0     0.0       0 HLT_Ele26_WP70_Unseeded
HLT-Report      50     200     200     200     152  76.00000     0.0     0.0       0 HLT_Photon108EB_TightID_TightIso_Unseeded
HLT-Report      51     200     200     200     156  78.00000     0.0     0.0       0 HLT_Photon187_Unseeded
HLT-Report      52     200     200     200     140  70.00000     0.0     0.0       0 HLT_DoubleEle25_CaloIdL_PMS2_Unseeded
HLT-Report      53     200     200     200     137  68.50000     0.0     0.0       0 HLT_Diphoton30_23_IsoCaloId_Unseeded
HLT-Report      54     200     200     200     170  85.00000     0.0     0.0       0 HLT_Ele32_WPTight_L1Seeded
HLT-Report      55     200     200     200     163  81.50000     0.0     0.0       0 HLT_Ele115_NonIso_L1Seeded
HLT-Report      56     200     200     200     168  84.00000     0.0     0.0       0 HLT_Ele26_WP70_L1Seeded
HLT-Report      57     200     200     200     152  76.00000     0.0     0.0       0 HLT_Photon108EB_TightID_TightIso_L1Seeded
HLT-Report      58     200     200     200     156  78.00000     0.0     0.0       0 HLT_Photon187_L1Seeded
HLT-Report      59     200     200     200     140  70.00000     0.0     0.0       0 HLT_DoubleEle25_CaloIdL_PMS2_L1Seeded
HLT-Report      60     200     200     200     113  56.50000     0.0     0.0       0 HLT_DoubleEle23_12_Iso_L1Seeded
HLT-Report      61     200     200     200     136  68.00000     0.0     0.0       0 HLT_Diphoton30_23_IsoCaloId_L1Seeded
HLT-Report      65     200     200     200     192  96.00000     0.0     0.0       0 MC_Ele5_Open_Unseeded
HLT-Report      66     200     200     200     188  94.00000     0.0     0.0       0 MC_Ele5_Open_L1Seeded

cmsbuild · 2024-01-30T06:35:57Z

cms-bot internal usage

SohamBhattacharya · 2024-01-30T06:38:34Z

HLTrigger/Configuration/python/HLT_75e33_cff.py

+#fragment.l1tGTProducer.CL2Jets = cms.InputTag("l1tSCPFL1PuppiCorrectedEmulator")
+#fragment.l1tGTProducer.CL2HtSum = cms.InputTag("l1tSCPFL1PuppiCorrectedEmulatorMHT")


Not sure if the HLT workflows will run with the recent change of the L1 collections.
To be enabled/removed if the workflows fail/run.

cmsbuild · 2024-01-30T06:43:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43809/38605

This PR adds an extra 56KB to repository

cmsbuild · 2024-01-30T06:44:15Z

A new Pull Request was created by @SohamBhattacharya for master.

It involves the following packages:

HLTrigger/Configuration (hlt)
RecoEgamma/EgammaHLTProducers (hlt)
RecoHGCal/TICL (upgrade, reconstruction)

@Martin-Grunewald, @srimanob, @subirsarkar, @jfernan2, @mandrenguyen, @mmusich, @cmsbuild can you please review it and eventually sign? Thanks.
@youyingli, @forthommel, @Martin-Grunewald, @wang0jin, @afiqaize, @lgray, @HuguesBrun, @lecriste, @jainshilpi, @Sam-Harper, @silviodonato, @Fedespring, @ebrondol, @hatakeyamak, @cericeci, @apsallid, @felicepantaleo, @thomreis, @ReyerBand, @ram1123, @rchatter, @argiro, @missirol, @varuns23, @a-kapoor, @sobhatta, @sameasy, @Prasant1993, @valsdav, @rovere this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2024-01-30T07:16:32Z

@cmsbuild, please test

cmsbuild · 2024-01-30T10:05:42Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d4fec4/37102/summary.html
COMMIT: d7c8281
CMSSW: CMSSW_14_0_X_2024-01-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43809/37102/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 14 lines to the logs
Reco comparison results: 70 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3248614
DQMHistoTests: Total failures: 1189
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3247403
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: found differences in 5 / 46 workflows

SohamBhattacharya · 2024-01-30T12:29:56Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d4fec4/37102/summary.html COMMIT: d7c8281 CMSSW: CMSSW_14_0_X_2024-01-29-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43809/37102/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

* You potentially [added 14 lines](https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_0_X_2024-01-29-2300+d4fec4/60800/validateJR/logRootQA-events.log) to the logs

* [Reco comparison results: 70 differences found in the comparisons](https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_0_X_2024-01-29-2300+d4fec4/60800/validateJR.html)

* DQMHistoTests: Total files compared: 48

* DQMHistoTests: Total histograms compared: 3248614

* DQMHistoTests: [Total failures: 1189](https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_0_X_2024-01-29-2300+d4fec4/60800/validateJR.html)

* DQMHistoTests: Total nulls: 0

* DQMHistoTests: Total successes: 3247403

* DQMHistoTests: Total skipped: 22

* DQMHistoTests: Total Missing objects: 0

* DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)

* Checked 200 log files, 161 edm output root files, 48 DQM output files

* [TriggerResults](https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_0_X_2024-01-29-2300+d4fec4/60800/triggerResults): found differences in 5 / 46 workflows

I believe the issue mentioned in #43790 is also observed here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_0_X_2024-01-29-2300+d4fec4/60800/validateJR/24834.911_TTbar_14TeV+2026D98_DD4hep/all_HLT_step2/c_edmTriggerResults_TriggerResults__HLT_obj_paths__5__accept.png

swagata87 · 2024-01-31T12:25:40Z

type egamma

cmsbuild · 2024-02-06T10:11:15Z

Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X.

mmusich · 2024-02-11T14:36:52Z

@cmsbuild, please test

cmsbuild · 2024-02-11T17:18:47Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d4fec4/37345/summary.html
COMMIT: d7c8281
CMSSW: CMSSW_14_1_X_2024-02-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43809/37345/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 67 lines to the logs
Reco comparison results: 50 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3248626
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3248604
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: found differences in 5 / 46 workflows

skeshri · 2024-02-12T08:02:44Z

Hi,

I have validated the efficiency of Electron and Photon paths before and after PR in CMSSW_14.
The results are consistent filter-wise and attached here:

Electron: https://skeshri-plots.web.cern.ch/skeshri-plots/HLT_Phase2_Validation/14_Ele_comparison/
Photon: https://skeshri-plots.web.cern.ch/skeshri-plots/HLT_Phase2_Validation/14_Photon_comparison/

SohamBhattacharya · 2024-02-12T09:58:48Z

Hi,

I have validated the efficiency of Electron and Photon paths before and after PR in CMSSW_14. The results are consistent filter-wise and attached here:

Electron: https://skeshri-plots.web.cern.ch/skeshri-plots/HLT_Phase2_Validation/14_Ele_comparison/ Photon: https://skeshri-plots.web.cern.ch/skeshri-plots/HLT_Phase2_Validation/14_Photon_comparison/

@skeshri thanks for the checks

Since the results are consistent, I believe this PR should be ready to be merged, unless there are other comments.

srimanob · 2024-02-12T10:04:49Z

+Upgrade

mmusich · 2024-02-12T10:10:39Z

+hlt

relying on the private validation of the proponents, see [14_1_X] [Phase-2] Change Phase-2 HLT Egamma paths to use the GT emulator #43809 (comment)

Martin-Grunewald · 2024-02-12T10:12:07Z

+1

jfernan2 · 2024-02-12T12:11:54Z

+1

cmsbuild · 2024-02-12T12:12:20Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-02-12T17:24:30Z

+1

SohamBhattacharya added 2 commits January 30, 2024 07:15

Change Phase-2 HLT Egamma paths to use the GT emulator.

5e24960

Disabled change of GT input collection in HLT_75e33_cff

d7c8281

cmsbuild added this to the CMSSW_14_0_X milestone Jan 30, 2024

cmsbuild added reconstruction-pending hlt-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending labels Jan 30, 2024

SohamBhattacharya commented Jan 30, 2024

View reviewed changes

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 30, 2024

cmsbuild added tests-started and removed tests-pending labels Jan 30, 2024

cmsbuild added tests-approved and removed tests-started labels Jan 30, 2024

cmsbuild added the egamma label Jan 31, 2024

SohamBhattacharya mentioned this pull request Feb 2, 2024

Inefficiency in electron paths in Phase2 HLT in 13_3_X #42850

Open

cmsbuild mentioned this pull request Feb 3, 2024

Fix Phase2 ditau HLT path (with DeepTau Isolation) #43855

Merged

cmsbuild modified the milestones: CMSSW_14_0_X, CMSSW_14_1_X Feb 6, 2024

cmsbuild added this to the CMSSW_14_1_X milestone Feb 7, 2024

SohamBhattacharya changed the title ~~[14_0_X] [Phase-2] Change Phase-2 HLT Egamma paths to use the GT emulator~~ [14_1_X] [Phase-2] Change Phase-2 HLT Egamma paths to use the GT emulator Feb 7, 2024

SohamBhattacharya mentioned this pull request Feb 9, 2024

[14_0_X] [backport] [Phase-2] Change Phase-2 HLT Egamma paths to use the GT emulator #43927

Merged

cmsbuild added tests-started and removed tests-approved labels Feb 11, 2024

cmsbuild added tests-approved and removed tests-started labels Feb 11, 2024

cmsbuild added upgrade-approved and removed upgrade-pending labels Feb 12, 2024

cmsbuild added hlt-approved and removed hlt-pending labels Feb 12, 2024

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Feb 12, 2024

cmsbuild added orp-approved and removed orp-pending labels Feb 12, 2024

cmsbuild merged commit 5639a95 into cms-sw:master Feb 12, 2024
11 checks passed

This was referenced Feb 13, 2024

Update Alpaka to version 1.1.0 #43772

Merged

Added test for PSet description wildcard with plugin #43944

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14_1_X] [Phase-2] Change Phase-2 HLT Egamma paths to use the GT emulator #43809

[14_1_X] [Phase-2] Change Phase-2 HLT Egamma paths to use the GT emulator #43809

SohamBhattacharya commented Jan 30, 2024

cmsbuild commented Jan 30, 2024 •

edited

Loading

SohamBhattacharya Jan 30, 2024 •

edited

Loading

cmsbuild commented Jan 30, 2024

cmsbuild commented Jan 30, 2024

mmusich commented Jan 30, 2024

cmsbuild commented Jan 30, 2024

SohamBhattacharya commented Jan 30, 2024

Comparison Summary

swagata87 commented Jan 31, 2024

cmsbuild commented Feb 6, 2024

mmusich commented Feb 11, 2024

cmsbuild commented Feb 11, 2024

skeshri commented Feb 12, 2024

SohamBhattacharya commented Feb 12, 2024

srimanob commented Feb 12, 2024

mmusich commented Feb 12, 2024

Martin-Grunewald commented Feb 12, 2024

jfernan2 commented Feb 12, 2024

cmsbuild commented Feb 12, 2024

antoniovilela commented Feb 12, 2024

		#fragment.l1tGTProducer.CL2Jets = cms.InputTag("l1tSCPFL1PuppiCorrectedEmulator")
		#fragment.l1tGTProducer.CL2HtSum = cms.InputTag("l1tSCPFL1PuppiCorrectedEmulatorMHT")

[14_1_X] [Phase-2] Change Phase-2 HLT Egamma paths to use the GT emulator #43809

[14_1_X] [Phase-2] Change Phase-2 HLT Egamma paths to use the GT emulator #43809

Conversation

SohamBhattacharya commented Jan 30, 2024

cmsbuild commented Jan 30, 2024 • edited Loading

SohamBhattacharya Jan 30, 2024 • edited Loading

Choose a reason for hiding this comment

cmsbuild commented Jan 30, 2024

cmsbuild commented Jan 30, 2024

mmusich commented Jan 30, 2024

cmsbuild commented Jan 30, 2024

Comparison Summary

SohamBhattacharya commented Jan 30, 2024

Comparison Summary

swagata87 commented Jan 31, 2024

cmsbuild commented Feb 6, 2024

mmusich commented Feb 11, 2024

cmsbuild commented Feb 11, 2024

Comparison Summary

skeshri commented Feb 12, 2024

SohamBhattacharya commented Feb 12, 2024

srimanob commented Feb 12, 2024

mmusich commented Feb 12, 2024

Martin-Grunewald commented Feb 12, 2024

jfernan2 commented Feb 12, 2024

cmsbuild commented Feb 12, 2024

antoniovilela commented Feb 12, 2024

cmsbuild commented Jan 30, 2024 •

edited

Loading

SohamBhattacharya Jan 30, 2024 •

edited

Loading