ECAL - Set correct CC tag labels for ECAL RecHit producer - 133x

[thomreis]

PR description:

While the ECAL uncalibrated RecHit producer is set up to use the timing calibrations and offsets from the CC labelled records in the GT for Run 3 and beyond (because the cross correlation timing algorithm is used in the time reconstruction), the RecHit producer has until now not picked the calibrations from the record with those labels. This mismatch in conditions used for the two producers is fixed with this PR.
The RecHit producer needs to use the conditions matching the reconstruction algorithm running in the uncalibrated REcHit producer.

In the online DQM the ratio timing is used and the record labels are explicitly set to be empty.

PR validation:

Passes the limited matrix tests.

Backport of #43795

[thomreis]

type ecal

[thomreis]

type bugfix

[cmsbuild]

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_13_3_X.

It involves the following packages:

• DQM/Integration (dqm)
• RecoLocalCalo/EcalRecProducers (reconstruction)

@mandrenguyen, @rvenditti, @jfernan2, @tjavaid, @antoniovagnerini, @nothingface0, @syuvivida, @cmsbuild can you please review it and eventually sign? Thanks.
@ReyerBand, @youyingli, @threus, @wang0jin, @argiro, @francescobrivio, @missirol, @apsallid, @thomreis, @rchatter, @batinkov this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from ECAL - Set correct CC tag labels for ECAL RecHit producer #43795

[cmsbuild]

cms-bot internal usage

[thomreis]

backport of #43795

[thomreis]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9daf46/37071/summary.html
COMMIT: 7777bb4
CMSSW: CMSSW_13_3_X_2024-01-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43800/37071/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 428 lines from the logs
• Reco comparison results: 168 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3364261
• DQMHistoTests: Total failures: 2595
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3361644
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+reconstruction

[thomreis]

Thanks for signing this PR @mandrenguyen . Can you please sign the master PR #43795 as well?

[mandrenguyen]

@thomreis It appears to me that I had also signed the PR to the master, but let me know if I'm hallucinating :-)

[thomreis]

@thomreis It appears to me that I had also signed the PR to the master, but let me know if I'm hallucinating :-)

You did, but it my open tab for that PR had been outdated. Sorry about that.

[cmsbuild]

Pull request #43800 was updated. @antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

[thomreis]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9daf46/37131/summary.html
COMMIT: d32ddc2
CMSSW: CMSSW_13_3_X_2024-01-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43800/37131/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 164 lines from the logs
• Reco comparison results: 171 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3364261
• DQMHistoTests: Total failures: 2631
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3361608
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[tjavaid]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1