L1Trk reco enabling CheckHistory by default

[tschuh]

This PR enables the CheckHistory option by default. Without this check there's a danger of people running CMSSW 14 L1Trk reco on stubs from earlier MC getting nonsense results and not realizing it. This PR got requested by @tomalin

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43690/38371

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @tschuh for master.

It involves the following packages:

• L1Trigger/TrackFindingTracklet (l1)
• L1Trigger/TrackerDTC (upgrade, l1)
• L1Trigger/TrackerTFP (l1)

@epalencia, @aloeliger, @subirsarkar, @srimanob, @cmsbuild can you please review it and eventually sign? Thanks.
@missirol, @erikbutz, @Martin-Grunewald, @skinnari this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[aloeliger]

@BenjaminRS I was pretty jet lagged yesterday and hadn't slept in 48 hours, so I'm not too sure, but I seem to recall this coming up yesterday, were you aware of this PR?

[aloeliger]

please test

[cmsbuild]

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-254412/36831/summary.html
COMMIT: d16d0f2
CMSSW: CMSSW_14_0_X_2024-01-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43690/36831/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 136.8311

----- Begin Fatal Exception 16-Jan-2024 10:50:07 CET-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=ElectronMVAValueMapProducer label='electronMVAValueMapProducer'
Exception Message:
edm::FileInPath unable to find file RecoEgamma/ElectronIdentification/data/MVAWeightFiles/Winter22HZZV1/EB1_5.weights.xml.gz anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43690/36831/CMSSW_14_0_X_2024-01-15-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43690/36831/CMSSW_14_0_X_2024-01-15-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43690/36831/CMSSW_14_0_X_2024-01-15-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.8311_RunJetHT2017FreMINIAOD
----- End Fatal Exception -------------------------------------------------

• 136.7611

----- Begin Fatal Exception 16-Jan-2024 10:50:07 CET-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=ElectronMVAValueMapProducer label='electronMVAValueMapProducer'
Exception Message:
edm::FileInPath unable to find file RecoEgamma/ElectronIdentification/data/MVAWeightFiles/Winter22HZZV1/EB1_5.weights.xml.gz anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43690/36831/CMSSW_14_0_X_2024-01-15-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43690/36831/CMSSW_14_0_X_2024-01-15-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43690/36831/CMSSW_14_0_X_2024-01-15-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.7611_RunJetHT2016EreMINIAOD
----- End Fatal Exception -------------------------------------------------

• 136.88811

----- Begin Fatal Exception 16-Jan-2024 10:50:08 CET-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=ElectronMVAValueMapProducer label='electronMVAValueMapProducer'
Exception Message:
edm::FileInPath unable to find file RecoEgamma/ElectronIdentification/data/MVAWeightFiles/Winter22HZZV1/EB1_5.weights.xml.gz anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43690/36831/CMSSW_14_0_X_2024-01-15-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43690/36831/CMSSW_14_0_X_2024-01-15-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43690/36831/CMSSW_14_0_X_2024-01-15-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.88811_RunJetHT2018DreMINIAODUL
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

• 4.53
• 135.4
• 140.023
• 139.001
• 136.731
• 136.793
• 136.874
• 158.01
• 140.043
• 140.063
• 9.0
• 25.0
• 1306.0
• 1330.0
• 312.0
• 141.042
• 13234.0
• 14034.0
• 141.044
• 141.046
• 14234.0
• 11634.0
• 25202.0
• 2500.4
• 12434.0
• 12446.0
• 12434.7
• 10224.0
• 24900.0
• 24896.0
• 12634.0
• 24834.0
• 23234.0
• 250202.181
• 25034.999
• 24834.911

RelVals-INPUT

• 4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
• 136.72411136.72411_RunJetHT2016B_reminiaodUL/step2_RunJetHT2016B_reminiaodUL.log
• 136.72412136.72412_RunJetHT2016B_reminiaodUL/step2_RunJetHT2016B_reminiaodUL.log

Expand to see more relval errors ...

• 136.7611
• 136.76111
• 136.7721
• 136.77211
• 136.8311
• 136.83111
• 136.88811
• 136.9
• 140.201
• 140.5611
• 140.202
• 158.01
• 159.01
• 1325.51
• 1325.5
• 1325.5161
• 1325.516
• 1325.517
• 1325.518
• 134.0
• 144.6
• 1002.0
• 24834.21
• 24034.0
• 13234.0
• 20834.501
• 20834.502
• 23634.0
• 20834.0
• 14034.0
• 13434.0
• 24834.103
• 14234.0
• 24834.0
• 24834.5
• 24834.9
• 24900.0
• 24896.0
• 25034.21
• 25034.114
• 2500.001
• 2500.0
• 2500.002
• 2500.3
• 2500.1
• 2500.2
• 2500.01
• 2500.011
• 2500.21
• 2500.211
• 2500.31
• 2500.311
• 2500.012
• 2500.4

[BenjaminRS]

@BenjaminRS I was pretty jet lagged yesterday and hadn't slept in 48 hours, so I'm not too sure, but I seem to recall this coming up yesterday, were you aware of this PR?

Thanks @aloeliger for the notification. I was not aware of the PR. Looks like with this in place it will now throw an exception if the tracking is run on earlier MC.

[aloeliger]

please test

[mmusich]

please test

What's the purpose of this re-test?

Looks like with this in place it will now throw an exception if the tracking is run on earlier MC.

This PR will never pass integration tests (see e.g. this log).

[aloeliger]

please test

What's the purpose of this re-test?

Looks like with this in place it will now throw an exception if the tracking is run on earlier MC.

This PR will never pass integration tests (see e.g. this log).

@mmusich Apologies, I was looking at the failed test earlier that seemed to have been a temporary issue and just retriggering as I had done for another L1 PR.

[aloeliger]

please abort

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43690/40847

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43690/40847/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43690/40847/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[tschuh]

I changed the code to only compare the last two processes. However, correct behavior would be to compare the current (which is the last) process with the one which produced the latest stub collection. I don't know how to identify that process. One option would be to give it as an config parameter.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43690/40848

[cmsbuild]

Pull request #43690 was updated. @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please check and sign again.

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

[antoniovilela]

ping (to make bot change milestone)

[tomalin]

Hi, this PR has been on hold for a long time. If people don't want this kind of check in CMSSW by default, could we at least please merge this PR with the "CheckHistory" default setting to "False", so we make available the bug fix to this check, for those people that wish to enable this option?

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.