Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed beginRun/endRun methods in TrackTriggerAssociation modules #43671

Merged

Conversation

Dr15Jones
Copy link
Contributor

PR description:

Moved printout to constructor.

This is part of framework change that will require stream modules to explicitly register to use Run/LuminosityBlock transitions.

PR validation:

Code compiles.

@Dr15Jones
Copy link
Contributor Author

@makortel FYI

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43671/38336

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2024

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • SimTracker/TrackTriggerAssociation (l1, simulation)

@civanch, @mdhildreth, @aloeliger, @epalencia can you please review it and eventually sign? Thanks.
@threus, @rovere, @GiacomoSguazzoni, @VourMa, @dgulhan, @missirol, @VinInn, @mmusich, @JanFSchulte, @mtosi this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec20bd/36724/summary.html
COMMIT: 77bd4fb
CMSSW: CMSSW_14_0_X_2024-01-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43671/36724/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@civanch
Copy link
Contributor

civanch commented Jan 6, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b23651f into cms-sw:master Jan 12, 2024
11 checks passed
@Dr15Jones Dr15Jones deleted the cleanupSimTrackerTrackTriggerAssociation branch January 12, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants