-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed beginRun/endRun methods in TrackTriggerAssociation modules #43671
Removed beginRun/endRun methods in TrackTriggerAssociation modules #43671
Conversation
Moved printout to constructor.
@makortel FYI |
please test |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43671/38336
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@civanch, @mdhildreth, @aloeliger, @epalencia can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+l1 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec20bd/36724/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Moved printout to constructor.
This is part of framework change that will require stream modules to explicitly register to use Run/LuminosityBlock transitions.
PR validation:
Code compiles.