Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Phase-2 workflow with Phase-2 ECal TP, also with ECal component #43635

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

srimanob
Copy link
Contributor

PR description:

This PR is to add new Phase-2 workflows with new Phase-2 ECAL TP, and with ECAL component. The L1T step is dropped at the moment, because we need to adapt few classes as template to support both simEcalEBTriggerPrimitiveDigis, simEcalEBTriggerPrimitivePhase2Digis. When it is done, these new workflows will be updated to be full chain again.

This PR is to allow to develop on top of new Phase-2 ECAL TP.

PR validation:

Run fine with 24834.634 (no L1T, no validation and DQM)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No need of backport.

@srimanob
Copy link
Contributor Author

FYI @nancymarinelli

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 22, 2023

cms-bot internal usage

@srimanob
Copy link
Contributor Author

test parameters:

  • workflows = 24834.633,24834.634,24834.635
  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,2026

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43635/38290

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@sunilUIET, @miquork, @AdrianoDee, @subirsarkar, @cmsbuild, @srimanob can you please review it and eventually sign? Thanks.
@slomeo, @makortel, @fabiocos, @Martin-Grunewald, @missirol this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a7ea5/36660/summary.html
COMMIT: 3e8c088
CMSSW: CMSSW_14_0_X_2023-12-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43635/36660/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 105 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3247277
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3247249
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor Author

srimanob commented Jan 6, 2024

+Upgrade

@srimanob
Copy link
Contributor Author

srimanob commented Jan 6, 2024

@cmsbuild please test

Retrigger the test after 2 weeks

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a7ea5/36728/summary.html
COMMIT: 3e8c088
CMSSW: CMSSW_14_0_X_2024-01-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43635/36728/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@srimanob
Copy link
Contributor Author

srimanob commented Jan 9, 2024

Kindly ping @cms-sw/pdmv-l2
Thx.

@srimanob
Copy link
Contributor Author

Ping @AdrianoDee @sunilUIET
Thx.

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 10c6043 into cms-sw:master Jan 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants