-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Phase-2 workflow with Phase-2 ECal TP, also with ECal component #43635
Conversation
FYI @nancymarinelli |
cms-bot internal usage |
test parameters:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43635/38290
|
A new Pull Request was created by @srimanob (Phat Srimanobhas) for master. It involves the following packages:
@sunilUIET, @miquork, @AdrianoDee, @subirsarkar, @cmsbuild, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a7ea5/36660/summary.html Comparison SummarySummary:
|
+Upgrade |
@cmsbuild please test Retrigger the test after 2 weeks |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a7ea5/36728/summary.html Comparison SummarySummary:
|
Kindly ping @cms-sw/pdmv-l2 |
Ping @AdrianoDee @sunilUIET |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is to add new Phase-2 workflows with new Phase-2 ECAL TP, and with ECAL component. The L1T step is dropped at the moment, because we need to adapt few classes as template to support both simEcalEBTriggerPrimitiveDigis, simEcalEBTriggerPrimitivePhase2Digis. When it is done, these new workflows will be updated to be full chain again.
This PR is to allow to develop on top of new Phase-2 ECAL TP.
PR validation:
Run fine with 24834.634 (no L1T, no validation and DQM)
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
No need of backport.