Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to 130X] Adding Two Secondary Datasets for JME POG #43538

Merged
merged 9 commits into from
Dec 12, 2023

Conversation

jordan-martins
Copy link
Contributor

Hi,

Backport of #43534

Thanks,
Jordan

@jordan-martins
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 10, 2023

A new Pull Request was created by @jordan-martins (Jordan Martins) for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@sunilUIET, @miquork, @AdrianoDee can you please review it and eventually sign? Thanks.
@youyingli, @fabiocos, @Martin-Grunewald, @missirol this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-72f928/36396/summary.html
COMMIT: 2990a2c
CMSSW: CMSSW_13_0_X_2023-12-10-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43538/36396/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3283620
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3283595
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@AdrianoDee
Copy link
Contributor

AdrianoDee commented Dec 11, 2023

@jordan-martins could you add a reference to the fact that this is a 13_0_X back port in the title? Just for the records, thanks.

@AdrianoDee
Copy link
Contributor

backport of #43534

@jordan-martins jordan-martins changed the title [Backport] Adding Two Secondary Datasets for JME POG [Backport to 130X] Adding Two Secondary Datasets for JME POG Dec 12, 2023
@jordan-martins
Copy link
Contributor Author

Ciao @AdrianoDee , like it is now? Please, let me know otherwise. Thanks, Jordan :)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4c47ab0 into cms-sw:CMSSW_13_0_X Dec 12, 2023
10 checks passed
@rappoccio rappoccio mentioned this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants