Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_2_X] Run3 era for 2023 PbPb UPC re-reco #43520

Merged

Conversation

stahlleiton
Copy link
Contributor

@stahlleiton stahlleiton commented Dec 7, 2023

PR description:

Backport of #43378 which creates a new era "Run3_2023_UPC" meant for the 2023 PbPb UPC re-reco.

PR validation:

Relval workflow 141.901 and private (documented in slides)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport from master (14_0_X) to 13_2_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2023

A new Pull Request was created by @stahlleiton (Andre Stahl) for CMSSW_13_2_X.

It involves the following packages:

  • Configuration/Eras (operations)
  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • Configuration/StandardSequences (operations)
  • PhysicsTools/PatAlgos (xpog, reconstruction)
  • RecoEgamma/EgammaElectronProducers (reconstruction)
  • RecoHI/HiCentralityAlgos (reconstruction)
  • RecoHI/HiTracking (reconstruction)
  • RecoJets/Configuration (reconstruction)
  • RecoTracker/Configuration (reconstruction)
  • RecoTracker/IterativeTracking (reconstruction)
  • RecoTracker/TkSeedGenerator (reconstruction)

@antoniovilela, @fabiocos, @simonepigazzini, @miquork, @rappoccio, @AdrianoDee, @vlimant, @sunilUIET, @davidlange6, @mandrenguyen, @jfernan2, @srimanob, @cmsbuild can you please review it and eventually sign? Thanks.
@jazzitup, @missirol, @andrzejnovak, @mbluj, @dgulhan, @AnnikaStein, @yetkinyilmaz, @yenjie, @Senphy, @makortel, @JanFSchulte, @demuller, @mariadalfonso, @ahinzmann, @kurtejung, @gkasieczka, @afiqaize, @lgray, @JyothsnaKomaragiri, @ram1123, @rappoccio, @gpetruc, @clelange, @valsdav, @mandrenguyen, @jdolen, @Ming-Yan, @sameasy, @felicepantaleo, @gouskos, @varuns23, @Prasant1993, @azotz, @mmarionncern, @VinInn, @schoef, @Martin-Grunewald, @fabiocos, @Sam-Harper, @sobhatta, @rovere, @AlexDeMoor, @mtosi, @GiacomoSguazzoni, @hatakeyamak, @jdamgov, @ebrondol, @slomeo, @nhanvtran, @jainshilpi, @a-kapoor, @VourMa, @seemasharmafnal, @emilbols, @mmusich this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor

backport of #43378

@mandrenguyen
Copy link
Contributor

please test

@mandrenguyen
Copy link
Contributor

please abort

@mandrenguyen
Copy link
Contributor

test parameters:

workflows = 141.901, 141.902

@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-05db03/36386/summary.html
COMMIT: 7a0429a
CMSSW: CMSSW_13_2_X_2023-12-08-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43520/36386/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198785
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198760
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+reconstruction

@srimanob
Copy link
Contributor

srimanob commented Dec 9, 2023

+Upgrade

@vlimant
Copy link
Contributor

vlimant commented Dec 10, 2023

+1

@stahlleiton
Copy link
Contributor Author

@cms-sw/pdmv-l2 please review/sign this PR

@stahlleiton
Copy link
Contributor Author

@cms-sw/pdmv-l2 would you kindly review/sign ?

@AdrianoDee
Copy link
Contributor

+pdmv

@antoniovilela
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit f5a6b8d into cms-sw:CMSSW_13_2_X Dec 19, 2023
11 checks passed
@antoniovilela
Copy link
Contributor

@smuzaffar
Hi Shahzad,
Do you understand why this PR was not automatically merged after all the signatures?
Thanks.

@smuzaffar
Copy link
Contributor

no idea but I am looking in to it @antoniovilela

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will be automatically merged.

@smuzaffar
Copy link
Contributor

@antoniovilela , fixed now. Due to latest bot changes, bot was waiting for non-blocking tracking to be approved. This has been fixed now

@antoniovilela
Copy link
Contributor

@antoniovilela , fixed now. Due to latest bot changes, bot was waiting for non-blocking tracking to be approved. This has been fixed now

Thanks!

@stahlleiton stahlleiton deleted the Era_Run3_UPC_2023_CMSSW_13_2_X branch December 19, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants